Implement structured logging #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M Essam Hamed <github@messam.xyz>
Signed-off-by: M Essam Hamed <github@messam.xyz>
mohamed-essam
requested review from
alvneiayu,
agarcia-oss and
alemorcuq
as code owners
Signed-off-by: M Essam Hamed <github@messam.xyz>
|
Thanks for submitting this PR, @mohamed-essam ! We will review it during this week. |
alemorcuq
requested changes
Jan 25, 2024
There was a problem hiding this comment.
Thanks @mohamed-essam! Please, check my comments. The PR looks awesome.
Signed-off-by: M Essam Hamed <github@messam.xyz>
alemorcuq
reviewed
Jan 25, 2024
Signed-off-by: M Essam Hamed <github@messam.xyz>
Signed-off-by: M Essam Hamed <github@messam.xyz>
alemorcuq
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Change controller logging to use
log/slog.Benefits
Possible drawbacks
N/A
Applicable issues
Additional information
--log-info-to-stdout, I had to implement a custom handler that would hand logs down to one of two slog.Loggers in place of the package inpkg/logthat handled this previously