-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/odoo] Add pre-install/pre-upgrade job for module installation. #25124
Conversation
27dd75e
to
b88e9b9
Compare
Signed-off-by: Rahma Ahmed <rahma.ahmed@oneacrefund.org>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Rahma Ahmed <rahma.ahmed@oneacrefund.org>
c4a4263
to
621ebdf
Compare
Signed-off-by: Rahma Ahmed <rahma.ahmed@oneacrefund.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestion but I have some doubts. Could you please check my comments.
## @param odooSkipModulesUpdate Skip Odoo update wizard | ||
## | ||
odooSkipModulesUpdate: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## @param odooSkipModulesUpdate Skip Odoo update wizard | |
## | |
odooSkipModulesUpdate: true | |
## @param odooSkipModulesUpdate Skip update of modules during the deployment | |
## | |
odooSkipModulesUpdate: false |
This would change the default behavior. I would not skip this by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jotamartos This should be used as part of the ternary operator with a value of true or false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my fault. In that case, use "false" instead of "no" but the idea is to follow the same approach we have in the container.
{{- if .Values.upgradeJob.command }} | ||
command: | ||
{{- include "common.tplvalues.render" (dict "value" .Values.command "context" $) | nindent 12 }} | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you do not provide a command, it'll basically run another pod with Odoo, will not simply update the plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated suggestion
## @param odooSkipModulesUpdate Skip Odoo update wizard | ||
## | ||
odooSkipModulesUpdate: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my fault. In that case, use "false" instead of "no" but the idea is to follow the same approach we have in the container.
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
Description of the change
This PR introduces a new Kubernetes job defined in the Odoo Helm chart, which is triggered during the pre-install and pre-upgrade phases. The job, named
odoo-addons-install
, utilizes arguments (args
) and environment variables (env
) from thevalues
file to configure and run the Odoo modules installation. This setup ensures that all necessary modules are installed and configured before any system updates or upgrades are applied, improving stability and consistency across deployments.Benefits
This job enhances the stability and reliability of the Odoo system by ensuring all necessary modules are pre-installed, which prevents conflicts during upgrades.
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using [readme-generator-for-helm] (https://github.com/bitnami/readme-generator-for-helm)