Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/odoo] Add pre-install/pre-upgrade job for module installation. #25124

Closed
wants to merge 4 commits into from

Conversation

samaroon
Copy link

@samaroon samaroon commented Apr 11, 2024

Description of the change

This PR introduces a new Kubernetes job defined in the Odoo Helm chart, which is triggered during the pre-install and pre-upgrade phases. The job, named odoo-addons-install, utilizes arguments (args) and environment variables (env) from the values file to configure and run the Odoo modules installation. This setup ensures that all necessary modules are installed and configured before any system updates or upgrades are applied, improving stability and consistency across deployments.

Benefits

This job enhances the stability and reliability of the Odoo system by ensuring all necessary modules are pre-installed, which prevents conflicts during upgrades.

Checklist

@github-actions github-actions bot added odoo triage Triage is needed labels Apr 11, 2024
@github-actions github-actions bot requested a review from carrodher April 11, 2024 02:37
@samaroon samaroon force-pushed the main branch 2 times, most recently from 27dd75e to b88e9b9 Compare April 11, 2024 03:45
@samaroon samaroon marked this pull request as ready for review April 11, 2024 03:48
Signed-off-by: Rahma Ahmed <rahma.ahmed@oneacrefund.org>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Apr 11, 2024
@github-actions github-actions bot removed the triage Triage is needed label Apr 11, 2024
@github-actions github-actions bot removed the request for review from carrodher April 11, 2024 07:26
Signed-off-by: Rahma Ahmed <rahma.ahmed@oneacrefund.org>
@samaroon samaroon force-pushed the main branch 8 times, most recently from c4a4263 to 621ebdf Compare April 17, 2024 06:30
Signed-off-by: Rahma Ahmed <rahma.ahmed@oneacrefund.org>
Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your suggestion but I have some doubts. Could you please check my comments.

Comment on lines +117 to +119
## @param odooSkipModulesUpdate Skip Odoo update wizard
##
odooSkipModulesUpdate: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## @param odooSkipModulesUpdate Skip Odoo update wizard
##
odooSkipModulesUpdate: true
## @param odooSkipModulesUpdate Skip update of modules during the deployment
##
odooSkipModulesUpdate: false

This would change the default behavior. I would not skip this by default

https://github.com/bitnami/containers/blob/main/bitnami/odoo/17/debian-12/rootfs/opt/bitnami/scripts/odoo-env.sh#L96

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jotamartos This should be used as part of the ternary operator with a value of true or false.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my fault. In that case, use "false" instead of "no" but the idea is to follow the same approach we have in the container.

Comment on lines +26 to +29
{{- if .Values.upgradeJob.command }}
command:
{{- include "common.tplvalues.render" (dict "value" .Values.command "context" $) | nindent 12 }}
{{- end }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do not provide a command, it'll basically run another pod with Odoo, will not simply update the plugins.

Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated suggestion

Comment on lines +117 to +119
## @param odooSkipModulesUpdate Skip Odoo update wizard
##
odooSkipModulesUpdate: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my fault. In that case, use "false" instead of "no" but the idea is to follow the same approach we have in the container.

Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label May 16, 2024
Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
odoo solved stale 15 days without activity verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants