Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/mariadb] PVCs labels not rendered #25375

Closed
wants to merge 1 commit into from

Conversation

csandanov
Copy link

PVCs labels rendered incorrectly

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Chingis Sandanov <chingis@wodby.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Apr 25, 2024
@github-actions github-actions bot removed the triage Triage is needed label Apr 25, 2024
@github-actions github-actions bot removed the request for review from carrodher April 25, 2024 08:16
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label May 11, 2024
@andresbono
Copy link
Member

Hi, thank you for proposing this change in the bitnami/mariadb chart. However, I don't really see the reason for the change. Can you describe the issue you are trying to fix? Using common.labels.matchLabels is a common pattern we use in several charts. Is there any problem with that?

In addition to that, I'm unable to render the helm templates after applying your changes:

$ helm template . -s templates/primary/statefulset.yaml | grep -A20 volumeClaimTemplates
Error: YAML parse error on mariadb/templates/primary/statefulset.yaml: error converting YAML to JSON: yaml: line 200: mapping values are not allowed in this context

Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mariadb solved stale 15 days without activity verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants