[Test] Reduce index branch size by squashing all commits #25712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jota Martos <jotamartos@vmware.com>
Signed-off-by: Jota Martos <jotamartos@vmware.com>
Signed-off-by: Jota Martos <jotamartos@vmware.com>
1 task
Signed-off-by: Jota Martos <jotamartos@vmware.com>
Signed-off-by: Jota Martos <jotamartos@vmware.com>
Signed-off-by: Jota Martos <jotamartos@vmware.com>
jotamartos
commented
May 14, 2024
Comment on lines
+21
to
+24
| # Configure AWS account | ||
| export $(printf "AWS_ACCESS_KEY_ID=%s AWS_SECRET_ACCESS_KEY=%s AWS_SESSION_TOKEN=%s" $(aws sts assume-role --role-arn ${AWS_ASSUME_ROLE_ARN} --role-session-name GitHubIndex --query "Credentials.[AccessKeyId,SecretAccessKey,SessionToken]" --output text)) | ||
| aws s3 cp --follow-symlinks bitnami/index.yaml s3://${{ secrets.AWS_S3_BUCKET }}/bitnami/ | ||
| aws s3 cp --follow-symlinks bitnami/index.html s3://${{ secrets.AWS_S3_BUCKET }}/ |
There was a problem hiding this comment.
We do not need to check when to run this because we are pushing to the index branch safely.
.github/workflows/cd-pipeline.yml
Outdated
| git fetch origin index | ||
| git reset --hard origin/index | ||
| current_commit_id=$(git rev-parse origin/index) | ||
| git reset --hard $(git commit-tree origin/index^{tree} -m "Update index.yaml") |
There was a problem hiding this comment.
This command gets the commits from remote and squash them.
.github/workflows/cd-pipeline.yml
Outdated
| git add bitnami/index.yaml && git commit -m "${chart_name}-${chart_version}: Update index.yaml" -s | ||
| git push && is_index_updated=1 || echo "Failed to push during attempt $attempts" | ||
| git add bitnami/index.yaml && git commit --signoff --amend --no-edit | ||
| git push --force-with-lease=index:${current_commit_id} && is_index_updated=1 || echo "Failed to push during attempt $attempts" |
There was a problem hiding this comment.
We are checking here that we are not pushing to remote if it changed during the execution of this job
Comment on lines
+91
to
+92
| yq eval '.entries[][].urls[]' indexes/last_index.yaml |sort| uniq > last_index_urls | ||
| yq eval '.entries[][].urls[]' archive-full-index/index.yaml | sort| uniq > index_urls |
There was a problem hiding this comment.
Paths were updated
| @@ -0,0 +1,123 @@ | |||
| name: '[Index] Generate the full bitnami/charts index.yaml' | |||
There was a problem hiding this comment.
This is a copy of the workflows in the index branch
carrodher
previously approved these changes
May 14, 2024
Signed-off-by: Jota Martos <jotamartos@vmware.com>
jotamartos
added a commit
that referenced
this pull request
May 15, 2024
Signed-off-by: Jota Martos <jotamartos@vmware.com>
1 task
jotamartos
added a commit
that referenced
this pull request
May 15, 2024
Signed-off-by: Jota Martos <jotamartos@vmware.com>
1 task
jotamartos
added a commit
that referenced
this pull request
May 15, 2024
jotamartos
added a commit
that referenced
this pull request
May 15, 2024
jotamartos
changed the title
This was referenced May 15, 2024
toobster
pushed a commit
to toobster/charts
that referenced
this pull request
May 15, 2024
* Reduce index branch size by squashing all commits Signed-off-by: Jota Martos <jotamartos@vmware.com> * Remove extra git reset line Signed-off-by: Jota Martos <jotamartos@vmware.com> * Add --signoff Signed-off-by: Jota Martos <jotamartos@vmware.com> * Ensure remote has not changed before pushing changes Signed-off-by: Jota Martos <jotamartos@vmware.com> * Move index branch workflows to main Signed-off-by: Jota Martos <jotamartos@vmware.com> * Fix file paths in archive-full-index.yaml Signed-off-by: Jota Martos <jotamartos@vmware.com> * Add temporary code to not test the changes Signed-off-by: Jota Martos <jotamartos@vmware.com> * Fix typo Signed-off-by: Jota Martos <jotamartos@vmware.com> --------- Signed-off-by: Jota Martos <jotamartos@vmware.com> Signed-off-by: Tobias Schneeberger <tobias.schneeberger@bernmobil.ch>
toobster
pushed a commit
to toobster/charts
that referenced
this pull request
May 15, 2024
Signed-off-by: Jota Martos <jotamartos@vmware.com> Signed-off-by: Tobias Schneeberger <tobias.schneeberger@bernmobil.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
These changes squash all commits in the branch every time the job is executed
Benefits
Repo size is reduced
Possible drawbacks
None AFAIK
Applicable issues
Additional information
Related to #25730
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm