Skip to content

[bitnami/external-dns] Major release: drop support for multiple replicas and DaemonSet #26759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 19, 2024

Conversation

migruiz4
Copy link
Member

@migruiz4 migruiz4 commented Jun 5, 2024

Description of the change

External DNS does not officially support deploying multiple replicas or DaemonSet architecture, and doing so may cause issues.

References:

Applicable issues

Additional information

Removed values:

  • replicaCount
  • useDaemonset
  • revisionHistoryLimit (DaemonSet-only)
  • podDisruptionBudget (Previously deprecated in favor of pdb.*)
  • metrics.serviceMonitor.additionalLabels (Previously deprecated in favor of metrics.serviceMonitor.labels)

Additionally, I added the missing standard value metrics.serviceMonitor.annotations

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…cas and DaemonSet

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Jun 5, 2024
@github-actions github-actions bot requested a review from jotamartos June 5, 2024 09:06
Signed-off-by: Miguel Ruiz <miruiz@vmware.com>
Bitnami Containers added 2 commits June 5, 2024 09:24
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
jotamartos
jotamartos previously approved these changes Jun 12, 2024
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@migruiz4 migruiz4 merged commit 3186d84 into main Jun 19, 2024
10 checks passed
@migruiz4 migruiz4 deleted the external-dns-single-replica branch June 19, 2024 07:08
@dangmai
Copy link

dangmai commented Jun 20, 2024

Hi, not sure why revisionHistoryLimit is removed in this PR? As far as I know that's used to determine how many old ReplicaSet that k8s keeps around (link), not how many replicas are currently running.
After this PR it will default to 10 and there's no way to customize it.

@bernermic
Copy link

bernermic commented Jun 20, 2024

Hi @migruiz4 and @jotamartos,
if there can be only one replica of externalDNS wouldn't it make sense to set pdb.create to false per default?
https://github.com/bitnami/charts/blob/d607a1af7dec0930f5fd730b7de2306ebc936997/bitnami/external-dns/values.yaml#L1198C5-L1203

Thanks for your good work :)

@bernermic
Copy link

I opened a PR #27467 which disables the pdb.

@DrFaust92
Copy link
Contributor

please rollback the revisionHistoryLimit change 🙏 it is required and unrelated to these changes

@jetersen
Copy link
Contributor

Created #27913 for the revisionHistoryLimit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami external-dns solved verify Execute verification workflow for these changes
Projects
None yet
7 participants