Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/haproxy] Add Configmap checksum annotation #7174

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

juan131
Copy link
Contributor

@juan131 juan131 commented Aug 10, 2021

Signed-off-by: juan131 juanariza@vmware.com

Description of the change

By adding an annotation including the checksum of the Configmap, we ensure that every time the configuration is updated by Helm the HA Proxy deployment will run a rolling update since this annotation will change.

Benefits

Pods are updated when the configuration changes.

Possible drawbacks

None

Applicable issues

Reported at #5424

Additional information

None

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Title of the PR starts with chart name (e.g. [bitnami/<name_of_the_chart>])

Signed-off-by: juan131 <juanariza@vmware.com>
Copy link
Contributor

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️❤️❤️

Copy link
Contributor

@marcosbc marcosbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@juan131 juan131 merged commit 2bbf5fe into bitnami:master Aug 10, 2021
@juan131 juan131 deleted the haproxy-configuration branch August 10, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants