Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unready-endpoints): use publishNotReadyAddresses #751

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

cndoit18
Copy link
Collaborator

@cndoit18 cndoit18 commented Nov 12, 2021

The annotation service.alpha.kubernetes.io/tolerate-unready-endpoints is deprecated. Users should use Service.spec.publishNotReadyAddresses instead.

link: kubernetes/kubernetes#63742

Signed-off-by: cndoit18 cndoit18@outlook.com


  • I've made sure the Changelog.md will remain up-to-date after this PR is merged.

The annotation `service.alpha.kubernetes.io/tolerate-unready-endpoints` is deprecated.  Users should
use Service.spec.publishNotReadyAddresses instead.

Signed-off-by: cndoit18 <cndoit18@outlook.com>
@cndoit18 cndoit18 force-pushed the deprecated-unready-annotations branch from 97b3902 to 60c9573 Compare November 12, 2021 08:04
Copy link
Member

@calind calind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calind calind merged commit e194651 into bitpoke:master Nov 15, 2021
@cndoit18 cndoit18 deleted the deprecated-unready-annotations branch November 15, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants