Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always specify packageType in command line (bundle/apk) #72

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

QuentinFarizon
Copy link
Contributor

@QuentinFarizon QuentinFarizon commented Aug 20, 2021

Checklist

Context

Cordova-android 10 made bundle package type the default : apache/cordova-android#1268
So using this step's option android_app_type: apk with cordova-android@10 still builds an aab (and make the step failed because apk result is not found)

Changes

Always specifying ---packageType has no downsides and make it compatible with all cordova-android versions.

@ofalvai
Copy link
Contributor

ofalvai commented Aug 23, 2021

Hey @QuentinFarizon, thank you for the contribution. We agree with the changes, it's a good idea to always specify the package type.

I wanted to make two small changes to this PR (since you checked the "allow changes from owners" checkbox), but my changes landed on a different branch and the commit is not part of this PR. I assume this happened because you opened this PR from your master and not from a separate branch.

Anyway, here are the changes that I wanted to make before merging this PR. One is a Golang style fix, the other is fixing the tests: 9899f21

@QuentinFarizon
Copy link
Contributor Author

I pushed with you changes integrated.
Sorry for the style, I'm not a go developer ;)

@ofalvai ofalvai merged commit 00ec8df into bitrise-steplib:master Aug 23, 2021
@ofalvai
Copy link
Contributor

ofalvai commented Aug 23, 2021

No worries and thank you for the contribution :) I merged the PR, the new step version will be available soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants