Bump https-proxy-agent dep. to 5.0.0 - This PR hopes to fix #181

[kitos9112]

Hi,

This PR is raised to bump a NodeJS dependency which people like us who use bitwarden CLI at work heavily rely on. As described in #181 this library introduced a bug for which we cannot log in successfully when running CLI commands behind an HTTP proxy.

I also bumped the third (patch I guess?) version of the tool.

Please, do review this small code change and let me know if I had to also update the package-lock.json - I don't do much JS lately.

Cheers,

[cscharf]

Thanks for the PR! Just a quick note that this package is used by multiple repositories and each of those would also need to be updated.

• jslib
• desktop
• directory-connector
• web
• cli (✅ )

If you wouldn't mind scatter-gunning those other repos with this update to the package version as well that would be much appreciated. Thanks again!

[kitos9112]

Hi @cscharf,

Yes, not a problem. I'll fork and raise MR accordingly.

Anything else left in this PR? Not quite sure why the CI job fails though :(

[kitos9112]

I've just gone through those listed repositories but only found https-proxy-agent dependency occurrences in the following ones:

• jslib (✅ )
• directory-connector (✅ )

Am I missing something? 🤔

[cscharf]

Am I missing something? 🤔

Yes, it's pretty obvious, you're missing the fact that I was wrong, lol, my apologies and I appreciate you looking! I did a global "search" but missed that each of those were picking up the sub-module jslib dependency in the package.json file, whoops.

[cscharf]

thanks! that should do it.

Not quite sure why the CI job fails though :(

It doesn't like the TypeScript syntax in one of the core files which hasn't changed in some time, likely something on the AppVeyor agent throwing a fit, the package for deployment scripts work okay when I run them locally. Either way, I don't believe it has anything to do with your change.