Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-2502][AC-2498] Update free org report upgrade dialog #9101

Conversation

aj-rosado
Copy link
Contributor

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Improve the upgrade dialog when the user tries to access the admin reports as a free org.
Showing the upgrade page open on the subscription page after pressing upgrade on the Reports upgrade dialog.

Code changes

  • is-paid-org.guard.ts: Instead of sending a message to the app.component.ts we are displaying it directly here, as it now shows a unique dialog for this case. Also passing the upgrade: true queryParams in order to display the upgrade as pre-selected.
  • messages.json: Added new texts for the reports upgrade.

Screenshots

Old
new upgrade dialog on reports

New
new upgrade dialog on reports

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@aj-rosado aj-rosado requested a review from a team as a code owner May 9, 2024 16:14
@aj-rosado aj-rosado requested a review from addisonbeck May 9, 2024 16:14
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 28.12%. Comparing base (121494f) to head (9a91356).

Files Patch % Lines
...-console/organizations/guards/is-paid-org.guard.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9101      +/-   ##
==========================================
- Coverage   28.12%   28.12%   -0.01%     
==========================================
  Files        2436     2436              
  Lines       70494    70496       +2     
  Branches    13136    13137       +1     
==========================================
  Hits        19829    19829              
- Misses      49130    49132       +2     
  Partials     1535     1535              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 9, 2024

Logo
Checkmarx One – Scan Summary & Details3a80e9cf-95a9-43f1-8ec8-954668af50a2

No New Or Fixed Issues Found

…ee-org-report-upgrade

# Conflicts:
#	apps/web/src/locales/en/messages.json
addisonbeck
addisonbeck previously approved these changes May 10, 2024
…ee-org-report-upgrade

# Conflicts:
#	apps/web/src/locales/en/messages.json
@aj-rosado aj-rosado removed the needs-qa Marks a PR as requiring QA approval label May 16, 2024
@aj-rosado aj-rosado merged commit 8cc113c into main May 16, 2024
33 of 35 checks passed
@aj-rosado aj-rosado deleted the tools/member-access-report/AC-2502/update-free-org-report-upgrade branch May 16, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants