Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-2500] Collection row menus - adjust feature flagging #9116

Merged
merged 4 commits into from
May 13, 2024

Conversation

eliykat
Copy link
Member

@eliykat eliykat commented May 10, 2024

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

After merging #9080, I noticed that some of my feature flagging was incomplete - e.g. the *ngIf to show/hide the collection row button did not check the flag value, even though the menu item itself did.

To avoid any behaviour affecting main, I've updated the canViewCollectionInfo getter to require the feature flag, and return false if it's not enabled. I then removed any redundant flag checks that were outside the getter.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@eliykat eliykat requested a review from a team as a code owner May 10, 2024 01:13
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 10, 2024
@eliykat eliykat requested review from shane-melton and removed request for LRNcardozoWDF May 10, 2024 01:14
@eliykat eliykat enabled auto-merge (squash) May 10, 2024 01:14
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 27.82%. Comparing base (8e4073f) to head (1ec4d93).

Files Patch % Lines
.../src/app/vault/core/views/collection-admin.view.ts 0.00% 2 Missing ⚠️
...lt/components/vault-items/vault-items.component.ts 0.00% 1 Missing ⚠️
...t/org-vault/vault-header/vault-header.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9116      +/-   ##
==========================================
- Coverage   27.82%   27.82%   -0.01%     
==========================================
  Files        2421     2421              
  Lines       70162    70164       +2     
  Branches    13088    13089       +1     
==========================================
  Hits        19521    19521              
- Misses      49121    49123       +2     
  Partials     1520     1520              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 10, 2024

Logo
Checkmarx One – Scan Summary & Detailsee8edd27-f348-4c8c-aae5-68c1f03eae30

No New Or Fixed Issues Found

@eliykat eliykat removed the needs-qa Marks a PR as requiring QA approval label May 10, 2024
@eliykat eliykat merged commit 8c5841a into main May 13, 2024
62 checks passed
@eliykat eliykat deleted the ac/ac-2500/feature-flagging branch May 13, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants