Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump https proxy agent #90

Merged
merged 3 commits into from
Feb 2, 2021
Merged

Bump https proxy agent #90

merged 3 commits into from
Feb 2, 2021

Conversation

eliykat
Copy link
Member

@eliykat eliykat commented Feb 1, 2021

Objective

Bump https-proxy-agent to v 5.0.0 per the discussion here.

Code changes

Bump of dependencies in package.json and package-lock.json.

@eliykat eliykat marked this pull request as draft February 1, 2021 07:00
@eliykat
Copy link
Member Author

eliykat commented Feb 2, 2021

@cscharf The remaining errors are because jslib has been upgraded to electron 11, but not directory-connector. Looks like Oscar's working on it. Once electron is upgraded, this build should pass. Not sure how you want to treat this PR in the meantime.

@eliykat eliykat marked this pull request as ready for review February 2, 2021 00:48
@eliykat eliykat requested a review from cscharf February 2, 2021 00:48
cscharf
cscharf reviewed Feb 2, 2021
View reviewed changes
Copy link
Contributor

@cscharf cscharf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 question, otherwise should be fine to merge once approved, before Oscar's electron update.

tsconfig.json Show resolved Hide resolved
@eliykat eliykat merged commit bdfda67 into master Feb 2, 2021
@eliykat eliykat deleted the bump-https-proxy-agent branch February 2, 2021 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cscharf cscharf cscharf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eliykat @cscharf