[AC-292] Public Api - allow configuration of custom permissions #4022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliykat
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4022 +/- ##
==========================================
+ Coverage 39.09% 39.75% +0.66%
==========================================
Files 1202 1203 +1
Lines 58110 58199 +89
Branches 5349 5358 +9
==========================================
+ Hits 22717 23139 +422
+ Misses 34323 33970 -353
- Partials 1070 1090 +20 ☔ View full report in Codecov by Sentry. |
…--configure-custom-permission-v2
…--configure-custom-permission-v2
r-tome
reviewed
May 8, 2024
…--configure-custom-permission-v2
…--configure-custom-permission-v2
r-tome
previously approved these changes
May 21, 2024
…--configure-custom-permission-v2
|
All test data is created with unique GUIDS, I think deleting data from the database would just make the tests run longer (and integration tests are already slow). I fixed a bug where it was checking the |
r-tome
approved these changes
May 23, 2024
…--configure-custom-permission-v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Allow users to configure custom permissions via the Public API.
This also involved refactoring the
OrganizationServiceinvite user methods so that I wasn't adding to existing tech debt. I also considered extracting this to a command, however this turned out to be non-trivial, so I think it's best tackled separately.Code changes
Following the commits in order:
OrganizationServicehad too many very similar methods for inviting users -InviteUserAsync(x2 overloads),SaveUserSendInviteAsync,InviteUsersAsync(x2 overloads), andSaveUsersSendInvitesAsync. It was difficult to keep track of the control flow and understand where changes needed to happen. I remember we did this originally to avoid exposing nullable parameters to outside callers, however I think the result has overall been worse for it. I combined several of these methods so that we just haveInviteUserAsync(single) ->InviteUsersAsync(multiple) -> privateSaveUsersSendInvitesAsync.LogSubjectwrapper which can represent an OrgUser or an EventUser and that's only unwrapped once it reaches EventService - but out of scope here.InviteUserAsynctook an increasing number of parameters and I didn't want to addPermissionshere. Refactor it to take anOrganizationUserInviteobject, similar toInviteUsersAsync. Refactor calling locations to create this object (often from an existing request object) and pass it in.Before you submit
dotnet format --verify-no-changes) (required)