[PM-7842] Fix validation of IDN emails #4036
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracking the flow of emails when signing up / changing emails (`[StrictEmailAddressAttribute]`): 1. (frontend) emails are checked using this regex: https://github.com/angular/angular/blob/17.3.6/packages/forms/src/validators.ts#L127 2. (backend) check for `ParseException` and `MimeKit.MailboxAddress.Parse(X).Address == X` 3. (backend) check "edge cases" regex 4. (backend) check `EmailAddressAttribute().IsValid` (https://github.com/Microsoft/referencesource/blob/master/System.ComponentModel.DataAnnotations/DataAnnotations/EmailAddressAttribute.cs#L54) The problem: 1. doesn't allow IDN 2. requires IDN 3. allows IDN 4. allows IDN This PR relaxes (2) to only check for ParseExceptions, allowing IDN to be specified in punycode form. Would have been nice if MimeKit had a ParserOptions to not turn punycode into IDN-form, but that is not the case: https://github.com/jstedfast/MimeKit/blob/master/MimeKit/InternetAddress.cs#L418-L419 Bitwarden already have a ton of (unit-)test-cases for handling IDN, so that should already be covered.
|
|
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bitwarden-bot
changed the title
|
Any updates on this? Another way of fixing this bug is by changing the Angular validator to not require emails to be punycoded 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Tracking the flow of emails when signing up / changing emails (
[StrictEmailAddressAttribute]):ParseExceptionandMimeKit.MailboxAddress.Parse(X).Address == XEmailAddressAttribute().IsValid(https://github.com/Microsoft/referencesource/blob/master/System.ComponentModel.DataAnnotations/DataAnnotations/EmailAddressAttribute.cs#L54)The problem:
This PR relaxes (2) to only check for ParseExceptions, allowing IDN to be specified in punycode form.
Would have been nice if MimeKit had a ParserOptions to not turn punycode into IDN-form, but that is not the case: https://github.com/jstedfast/MimeKit/blob/master/MimeKit/InternetAddress.cs#L418-L419
Bitwarden already have a ton of (unit-)test-cases for handling IDN, so that should already be covered.