-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-2513] Scaling PM seat count with SM seat count #4040
[AC-2513] Scaling PM seat count with SM seat count #4040
Conversation
… to reduce boilerplate
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4040 +/- ##
=======================================
Coverage ? 38.39%
=======================================
Files ? 1210
Lines ? 58676
Branches ? 5589
=======================================
Hits ? 22531
Misses ? 35102
Partials ? 1043 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I left a few suggestions but none are blockers.
Also, thanks for suggesting to look through the commit history, that helped to review this 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these changes!
Type of change
Objective
For organizations who have signed up for the Secrets Manager free trial via https://vault.bitwarden.com/#/register?org=teams&layout=secretsManager, this PR scales the organization's Password Manager seat count in step with adjustments to the organization's Secrets Manager seat count. We know when an organization has signed up to trial secrets manager because we're already applying a discount to the Password Manager subscription item. By checking for that discount, we can decide if we should scale Password Manager seats along with Secrets Manager.
This is due to a couple of factors:
We'll be splitting Secrets Manager to be a standalone product later this year, such that a user won't have to sign up for Password Manager in order to sign up for Secrets Manager. Until we do that, we need to do some goofy things like this to simulate that they're currently different products.
In addition, I've separated out endpoints from the Admin Console OrganizationsController.cs that are billing related into a new Billing owned OrganizationsController (same routes). As a result, the diff will be hard to read. I recommend first looking at the commit history, as I've committed in logical steps to the above description. The first commit shows the business change as requested by product, the subsequent commits are the codeowner changes. Feel free to comment on any of it.
Client-side PR: bitwarden/clients#9011
Code changes
GetBilling
endpoint to this controller since it matches the base routeGET {id}/billing-status
. Added new business logic toPOST {id}/sm-subscription
that scales PM seat counts with SM seat changes for SM standalone organizationsRecording.2024-05-02.091734.mp4
Before you submit
dotnet format --verify-no-changes
) (required)