[AC-2480] Hiding teams starter option #4044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4044 +/- ##
=======================================
Coverage ? 38.40%
=======================================
Files ? 1209
Lines ? 58674
Branches ? 5587
=======================================
Hits ? 22532
Misses ? 35098
Partials ? 1044 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
| @@ -70,9 +70,10 @@ | |||
| @{ | |||
| var planTypes = Enum.GetValues<PlanType>() | |||
| .Where(p => | |||
| Model.Provider == null || | |||
| (Model.Provider != null | |||
There was a problem hiding this comment.
Removed redundant Model.Provider != null since it's always not null if it reaches this side of the ||.
| (Model.Provider == null || | ||
| p is >= PlanType.TeamsMonthly2019 and <= PlanType.EnterpriseAnnually2019 or | ||
| >= PlanType.TeamsMonthly2020 and <= PlanType.EnterpriseAnnually) && | ||
| p != PlanType.TeamsStarter |
There was a problem hiding this comment.
Added this extra conditional, p != PlanType.TeamsStarter, to hide that plan
| @@ -28,6 +28,8 @@ public TeamsStarterPlan() | |||
|
|
|||
| PasswordManager = new TeamsStarterPasswordManagerFeatures(); | |||
| SecretsManager = new TeamsStarterSecretsManagerFeatures(); | |||
|
|
|||
| LegacyYear = 2024; | |||
There was a problem hiding this comment.
This hides the plan on the frontend here
vincentsalucci
approved these changes
May 2, 2024
cyprain-okeke
pushed a commit
that referenced
this pull request
May 20, 2024
cyprain-okeke
pushed a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Product is discontinuing the "Teams Starter" plan, and as such, we're removing it from the app. Current teams starter organizations are unaffected, which is why the plan is archived instead of outright deleted.
"Teams Starter 2023" is already archived, so you won't see any changes for it.
Client side PR: bitwarden/clients#9017
Code changes
LegacyYearvalue to hide this planBefore you submit
dotnet format --verify-no-changes) (required)