[PM-5157] Update duo metadata #4071
Closed
+7,945
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ike-kottlowski
requested review from
rr-bw and
amorask-bitwarden
and removed request for
rr-bw
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4071 +/- ##
==========================================
- Coverage 38.66% 38.63% -0.04%
==========================================
Files 1209 1209
Lines 58561 58577 +16
Branches 5594 5595 +1
==========================================
- Hits 22643 22629 -14
- Misses 34863 34896 +33
+ Partials 1055 1052 -3 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
| @@ -217,8 +226,16 @@ public async Task<TwoFactorDuoResponseModel> PutDuo([FromBody] UpdateTwoFactorDu | |||
|
|
|||
| try | |||
| { | |||
| var duoApi = new DuoApi(model.IntegrationKey, model.SecretKey, model.Host); | |||
| await duoApi.JSONApiCall("GET", "/auth/v2/check"); | |||
There was a problem hiding this comment.
❓ was the removal of await duoApi.JSONApiCall("GET", "/auth/v2/check"); intentional?
There was a problem hiding this comment.
❓ : Do we have tests for this controller which could cover these endpoints and these new scenarios?
There was a problem hiding this comment.
Testing the DuoApi proved to be tricky and not worth the trouble due to the removal of DuoApi in a later release.
|
closing this PR to match the correct branch name and PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Rename Duo properties to match Duo version 4 updates.
⭐ Side Quest: Added entity Framework migration for
Providers.GatewayType.Code changes
ClientIdandClientSecretto duo responses and requests.Provider.GatewayTypeBefore you submit
dotnet format --verify-no-changes) (required)