Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-5295] Implement feature flag that allows us to fallback to using … #4076

Conversation

cagonzalezcs
Copy link
Contributor

…the TreeWalker API in the extension when collecting page details for autofill

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [x] Other

Objective

A rework of how we collect page details for autofill in the browser extension is moving away entire from using the JavaScript TreeWalker API. In an effort to be cautious for this change, we'd like to introduce a short-lived feature flag that allows us to fallback to the TreeWalker API in the event that the reworked approach does not function as expected.

Code changes

  • src/Core/Constants.cs: Adding a feature flag that allows us to fallback to the TreeWalker API approach when collecting page details.

…the TreeWalker API in the extension when collecting page details for autofill
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.10%. Comparing base (ba93c00) to head (71c5a33).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4076   +/-   ##
=======================================
  Coverage   39.10%   39.10%           
=======================================
  Files        1203     1203           
  Lines       58182    58182           
  Branches     5355     5355           
=======================================
  Hits        22752    22752           
  Misses      34360    34360           
  Partials     1070     1070           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment was marked as off-topic.

@cagonzalezcs cagonzalezcs merged commit 517fa1e into main May 24, 2024
49 checks passed
@cagonzalezcs cagonzalezcs deleted the autofill/pm-5295-improve-autofill-collection-of-page-details-performance branch May 24, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants