[AC-2328] Add a Bulk OrganizationUsersController.GetResetPasswordDetails endpoint #4079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple organization user IDs
…rganizationUserAsync
…organization users
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4079 +/- ##
==========================================
+ Coverage 39.05% 39.08% +0.03%
==========================================
Files 1202 1202
Lines 58081 58118 +37
Branches 5350 5351 +1
==========================================
+ Hits 22684 22717 +33
- Misses 34328 34330 +2
- Partials 1069 1071 +2 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
cturnbull-bitwarden
previously approved these changes
May 13, 2024
addisonbeck
requested changes
May 13, 2024
| @@ -186,6 +186,19 @@ public async Task<OrganizationUserResetPasswordDetailsResponseModel> GetResetPas | |||
| return new OrganizationUserResetPasswordDetailsResponseModel(new OrganizationUserResetPasswordDetails(organizationUser, user, org)); | |||
| } | |||
|
|
|||
| [HttpPost("reset-password-details")] | |||
There was a problem hiding this comment.
Reset master password has been renamed "account recovery" across the product and documentation, but we still have a lot of lingering code calling things by the old "reset master password" name. Part of the tech debt epic to clean up account recovery (here) is going to involve renaming code to use "account recovery" verbiage.
We can avoid having to rename this endpoint and its backing logic later if we go ahead and call this by the correct name now. I'd like to suggest we dump any new instances of "reset password" and replace them with "account recovery", so this endpoint would be at /account-recovery-details and the method would be called GetAccountRecoveryDetails. This could be followed through to the new repository method too and name it GetManyAccountRecoveryDeatilsByOrganizationUserAsync. I think the rest of the names are used in other bits of code, so those should be left alone.
Comment on lines
9
to
12
| public OrganizationUserResetPasswordDetails() | ||
| { | ||
|
|
||
| } |
There was a problem hiding this comment.
This can be a one-liner
| @@ -3,7 +3,6 @@ | |||
| using Bit.Billing.Services; | |||
| using Bit.Core; | |||
| using Bit.Core.AdminConsole.Entities; | |||
| using Bit.Core.AdminConsole.Enums.Provider; | |||
There was a problem hiding this comment.
I logged a separate PR for this lint failure stuff here
| @@ -43,6 +43,7 @@ public interface IOrganizationUserRepository : IRepository<OrganizationUser, Gui | |||
| Task RestoreAsync(Guid id, OrganizationUserStatusType status); | |||
| Task<IEnumerable<OrganizationUserPolicyDetails>> GetByUserIdWithPolicyDetailsAsync(Guid userId, PolicyType policyType); | |||
| Task<int> GetOccupiedSmSeatCountByOrganizationIdAsync(Guid organizationId); | |||
| Task<IEnumerable<OrganizationUserResetPasswordDetails>> GetManyResetPasswordDetailsByOrganizationUserAsync(Guid organizationId, IEnumerable<Guid> organizationUserIds); | |||
There was a problem hiding this comment.
Lets add an integration test for this in test/Infrastructure.IntegrationTest/AdminConsole/Repositories/OrganizationUserRepositoryTests.cs.
| @@ -0,0 +1,24 @@ | |||
| CREATE PROCEDURE [dbo].[OrganizationUser_ReadManyResetPasswordDetailsByOrganizationUserIds] | |||
There was a problem hiding this comment.
Similar to my comment about naming things in the controller and repository layers: this stored procedure name should use "account recovery" verbiage instead of the outdated "reset password". We can't do anything about the column right now, but that should be included in the tech debt epic.
|
Also, in regards to the question on slack about what to do with the single-response method: We should log refactoring that method as follow up work on the Jira epic. My preference would be to leave the endpoint and have it reference the same repository logic, leaving |
…account recovery details
addisonbeck
previously approved these changes
May 15, 2024
addisonbeck
previously approved these changes
May 21, 2024
LaunchDarkly flag references🔍 1 flag added or modified
|
addisonbeck
approved these changes
May 23, 2024
rkac-bw
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
The current endpoint requires multiple database calls, this new endpoint gets all data using one new stored procedure.
Code changes
Clients PR
@bitwarden/team-billing-dev, you've been added as reviewers because
dotnet formatremoved a few usings onStripeControllerOrganizationUserIdproperty to be able to identify each one on the result listOrganizationUserIdproperty and a parameterless constructor for the auto mapperBefore you submit
dotnet format --verify-no-changes) (required)