feat: add visionOS support #3289
Open
+110
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Follow existing file name convention when adding new files... |
bkaradzic
requested changes
May 9, 2024
bkaradzic
reviewed
May 9, 2024
|
You should investigate how to avoid using 4 files for visionOS entry. Ideally only one file would be there. |
Co-authored-by: mani3xis <mariusz.pas+dev@protonmail.com> fix: properly set storageMode cleanup: remove unused variables fix crash while releasing m_drawable on visionOS fix: remove unused timing variable fix: file name cases, cleanup feat: integrate visionOS into bgfx examples
|
Hey @bkaradzic, I've removed "example" needed changes from this PR. I will open a separate one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR adds visionOS support to bgfx. It's the continuation of this PR which added support to
bxlibrary. I've worked on this together with @mani3xis.Apple Vision uses bgfx in single threaded mode (
BGFX_CONFIG_MULTITHREADED = 0), but the example framework isn't really working nice with single threaded mode, so there might be some crashes in the examples but it works great when integrated separately.