[pull] master from web-platform-tests:master #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
According to the manifest these are all testharness tests, but WebKit's historic slightly different logic has led to these being run in a bogus state previously (where they were treated as both a reftest and a testharness test all at once).
It's not overly meaningful to have a reference while also being manual, and all this is really testing is that the click event is fired, so let's just turn this into a testharness test using testdriver.
We already check whether tests crash, so we may as well check the rendering too.
This is similar to the TESTHARNESS-IN-OTHER-TYPE lint
Sub-LineBreakers always referred to InlineItems for ::first-line incorrectly because the constructor for them don't have an InlineBreakToken. This CL fixes it by passing the parent LineBreaker through SetInputRange(), then PrepareNextLine() updates items_data_. Bug: 324111880 Change-Id: I1c19b727335fb1b636f731b58155789b60480c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528710 Reviewed-by: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1299875}
As per the spec for: * `text-box-trim`: https://drafts.csswg.org/css-inline-3/#propdef-text-box-trim * `text-box-edge`: https://drafts.csswg.org/css-inline-3/#propdef-text-box-edge Bug: 41494590 Change-Id: I934e272f964fce6f2c57818c94102046fc0f309a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5532122 Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1299895}
Page borders and padding shouldn't be affected by layout scaling. Since the page border box lives in the coordinate system of layout, the values need to be scaled down when computing style. The insets caused by @page borders and padding will naturally shrink the size available to the page content area. As such CalculateChildAvailableSize() needs an update now. The page container and border boxes *are* anonymous blocks, but their block-size should be allowed to be adjusted nevertheless. Only prevent block-size adjustment if it's indefinite (which is never the case for page containers or page border boxes). Bug: 40286153 Change-Id: Ie701aa65cd5f23820d3a8de3e40958342a106174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526033 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1299923}
…the web platform test html/rendering/replaced-elements/the-select-element/select-1-block-size-001-ref.html; DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D209876 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1893348 gecko-commit: b31c8fc31e2ea92bb107f3ca1c48c321b73d3f9c gecko-reviewers: dholbert
…d-position anchor" This reverts commit 94af1f503694c3a7ffece9c910516b3bbe9d50c2. Reason for revert: Causing crashes in GC, see bug. Bug: 339967265, 338929745 Original change's description: > [css-anchor-position-1] Fix flicker with try-option with fixed-position anchor > > Previously we supposed the default anchor wouldn't change in > try-options, but the latest draft spec allows that. > > When the currently tried option will use a default anchor that is > different from the currently used default anchor, checking overflow > with the snapshotted AnchorPositionScrollData will be incorrect, > and the incorrect results caused oscillation between try options. > > To resolve that, when the total offset is requested for a different > default anchor, we need to calculate it on the fly instead of getting > it from the snapshotted result. > > Also allow one more layout if ValidateSnapshot() (called after the > first layout in a document lifecycle update) finds that the > snapshotted scroll data needs update, to ensure correct layout and > paint with the changed anchor and scroll adjustment in most cases. > > In rare cases when we need more than one additional layout to get > the stable layout, ShouldScheduleNextService() will schedule another > lifecycle. > > Fixed: 338929745 > Change-Id: I295fbc605ac8b7f0298eef7aeff4434c6bd54628 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5529048 > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1299608} Change-Id: I222274aa6af5da55d5d6dc0867d3cda684efff49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526668 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#1299965}
See whatwg/html#9979 & whatwg/html#8229 for context.
This patch adds a new runtime enabled feature for ::search-text (SearchTextHighlightPseudo), new PseudoId and PseudoType and devtools protocol variants for ::search-text and :current, and extends the selector parser to accept ::search-text and ::search-text:current when the feature is enabled. :current has an alternate functional form [1] that, at least in a WebVTT context, allows you to match ancestors of the current element. Parsing this will be left to a separate patch. [1] https://drafts.csswg.org/selectors/#the-current-pseudo Bug: 339298411 Change-Id: I2f12acd9580ae03dbdd816a03cbb68017864d136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5515107 Commit-Queue: Delan Azabani <dazabani@igalia.com> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/main@{#1299975}
Many of the subtests depend on transition-behavior via interpolation-testcommon.js.
…this attribute is not in the spec (#46231) Replace 2d.text.measure.advances test with a test that asserts `advances` does not exist, as it is not in the spec.
Calculating the page area size is very similar to how the content box size of a regular non-replaced CSS box is calculated. content box + padding + border + margin = size of containing block The only differences: 1. percentage-based padding/margins in a given dimension are resolved against the containing block size in that dimension (i.e. a percentage-based margin-top is resolved against the containing block *height*), not unconditionally against the inline-size of the containing block (regular CSS boxes) 2. Overconstrainedness is resolved differently. Rather than adjusting margins to fix the equation, the containing block size is adjusted. Auto @page margins are also handled correctly now. Tests included. Clean up pagination stuff in Document, and move the logic of GetPageDescription() into pagination utils in layout, and only call it from external APIs (we used to need it during layout as well, but not anymore). The end goal here is to be able to implement this by examining the physical fragments, but we're not quite there yet, since Blink still doesn't control the margin area of the page. Improve detection of unusable page sizes (if margins+border+padding are larger than the containing block). We'll now recalculate computed style for such page containers, and just ignore all author styles. Bug: 40286153 Change-Id: Id660b7e60d71256f32cb56db1cf419ad8ac91c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5522379 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1299921} Co-authored-by: Morten Stenshorne <mstensho@chromium.org>
This CL implements iframe-specific logic for state-preserving atomic moves, as well as some web platform tests and unit tests. We test specifically that iframe documents are not reloaded during a call to `moveBefore()`, and that the order of frames in `window.frames` remains untouched. Much of the implementation revolves around how we manage internal bookkeeping of subframe counts; this bookkeeping is used for real world behavior in the node insertion/removal path [1], internal optimizations [2], and Blink logic consistency assertions. There is still implementation work general to all nodes (non-iframe-specific) to be done for state-preserving atomic moves overall, like suppressing mutation events, and tweaking how MutationObserver reacts to `moveBefore()` calls. That work will be done in follow-up CLs. [1]: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/dom/container_node.cc;l=834-836;drc=1f0fdce87dc82416abdf7ace3e096e3dbfc7d405 [2]: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/dom/child_frame_disconnector.cc;l=21-22;drc=047c7dc4ee1ce908d7fea38ca063fa2f80f92c77 Bug: 40150299 Change-Id: If22ce5f96f8fbe98e126f2e8909aa852e5307bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5314005 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1300121}
This CL primarily does two things:
1. Use TFLite backend (instead of XNNPACK) on Linux for "cpu" contexts
2. Refactor the existing Virtual Test Suite on Linux to run "cpu"
tests now that the "gpu" workaround is no longer needed to target
the TFLite backend
Note that - assuming TFLite-on-CPU behaves the same across platforms -
this "cpu" Virtual Test Suite and the corresponding expectations will
be re-used as other backends (or at least Windows) migrate "cpu"
context execution to TFLite in follow-up CLs
Before (on Linux):
- using a "cpu" context targets the XNNPACK backend in the renderer
- using a "gpu" context targets the TFLite backend in
//services (which currently runs on CPU anyways)
After (on Linux):
- using either a "cpu" or "gpu" context targets the TFLite backend in
//services
This opens the door for TFLite to truly target the GPU if instructed,
and gets us one step closer to removing the XNNPACK backend
Bug: 325612086
Change-Id: I421d97b7d91b604afbfb3c8aa71b55a5bc78bd6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5532576
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: Austin Sullivan <asully@chromium.org>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1300171}
Remove the margin handling code from PrintRenderFrameHelper (used by the actual browser) and SpoolPagesWithBoundariesForTesting() (web tests). This allows @page backgrounds to cover the entire page box, including the margin area. Tests included. This CL also paves the road for implementing @page margin boxes (such as author-specified headers and footers), which was the main objective anyway. The fact that Blink is now responsible for the entire page box means that the code that deals with shrinking / centering paginated content to fit the target paper also has to be moved over to Blink. WebPrintPageDescription still provides margin info for each page. Although PrintRenderFrameHelper no longer needs to position the page area within the page box based on margins, the margins are still needed in order to figure out if there's enough room for UA-generated headers and footers. By moving all of this into Blink, it will be rather straight-forward to add web tests for page fitting, rather than writing clunky PrintRenderFrameHelper component browser tests for it. Will follow up with a CL for this. Three page-orientation tests now start passing. The code in SpoolPagesWithBoundariesForTesting() didn't add margin translation at the correct time when rotating. The margins are no longer added there, so the problem is gone. Bug: 40286153, 40341678 Change-Id: I418b2e08ed76b297ea5d5fc223545b52b3e9b09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526464 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1300225}
This reverts commit 66b9710a5337aaefeb1a4e71ba5675b2a8744cb2. Reason for revert: crbug.com/339684347 Original change's description: > [text-box-trim] Fix `text-box-edge` to be inherited > > As per the spec for: > * `text-box-trim`: https://drafts.csswg.org/css-inline-3/#propdef-text-box-trim > * `text-box-edge`: https://drafts.csswg.org/css-inline-3/#propdef-text-box-edge > > Bug: 41494590 > Change-Id: I934e272f964fce6f2c57818c94102046fc0f309a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5532122 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Auto-Submit: Koji Ishii <kojii@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1299895} Bug: 41494590, 339684347 Change-Id: I4768cd2ba204b147a8e9bd8ac5459393763c7d91 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5533288 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1300233}
Putting the svg in a data url for background-image was not as customizable in CSS for developers, but using an actual svg element is: openui/open-ui#881 Bug: 40146374 Fixed: 337904202 Change-Id: If1528b3df97e31de5b86b27a6aa935223ff0f0a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5522663 Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1300224} Co-authored-by: Joey Arhar <jarhar@chromium.org>
This implements the new proposal here: fedidcg/FedCM#559 If one or two but not all of ["name", "email", "picture"] are requested, we reject the promise. Otherwise, we show the disclosure text if either field is not specified or contains the three default fields. All specified fields are passed to the server in the "fields" parameter; if fields was unspecified we pass the default fields here. All this is for forwards compatibility. Bug: 40262526, 340194462 Change-Id: I13833691e5f2851f0dc8e9568d007e57a47b8127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5529071 Reviewed-by: Yi Gu <yigu@chromium.org> Reviewed-by: Brendon Tiszka <tiszka@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/main@{#1300264}
Bug #1: AbstractRange::(Mark|Unmark)Descendants should always use the shadow tree of web-exposed shadow root, instead of using light DOM elements of the host. Bug #2: aRange could possibly create mCrossShadowBoundaryRange first (due to boundaries are in different tree), and later moves the boundaries to the same tree. When this happens, we should remove mCrossShadowBoundaryRange and use the default range to represent it. Differential Revision: https://phabricator.services.mozilla.com/D207608 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1891783 gecko-commit: 0f54a84c32d1c22d71ff7307944b824639adbd6f gecko-reviewers: jjaschke, smaug, dom-core
Differential Revision: https://phabricator.services.mozilla.com/D207472 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1396922 gecko-commit: c9bfe7c044aacff41982fd440ae2f83476c1318b gecko-reviewers: bwc, jib, webidl, smaug
In a recent update to the spec (see OpenUI bug openui/open-ui#859 and spec update at https://open-ui.org/components/focusgroup.explainer/ the focusgroup direction have changed from physical descriptions "horizontal" and "vertical" to logical CSS terms that imply the direction limitations adapt to content direction: "inline" and "block". This change (my first), is a simple rename of terms "horizontal" and "vertical" to "inline" and "block" respectively. Other than the attribute value parsing changes and related enums and function names, this change does not actually [yet] consider the inline and block direction when handling directional arrow keys from user input. That will be saved for a future change. Specific changes in this CL: - `FocusgroupFlags::kHorizontal` --> `::kInline` - `FocusgroupFlags::kVertical` --> `::kBlock` - `FocusgroupFlags::kWrapHorizontally` --> `::kWrapInline` - `FocusgroupFlags::kWrapVertically` --> `::kWrapBlock` - `FocusgroupFlags::kWrapVertically` --> `::kWrapBlock` - `FocusgroupDirection::kForwardHorizontal` --> `::kForwardInline` - `FocusgroupDirection::kForwardVertical` --> `::kForwardBlock` - `FocusgroupDirection::kBackwardHorizontal` --> `::kBackwardInline` - `FocusgroupDirection::kBackwardVertical` --> `::kBackwardBlock` - `FocusgroupControllerUtils::IsDirectionHorizontal()` -> `IsDirectionInline()` - `FocusgroupControllerUtils::IsDirectionVertical()` -> `IsDirectionBlock()` Web tests impacted by this change are updated (and the corresponding spec link is also updated). Bug: 4021071 Change-Id: Ic3c9a5dc56c0d48f8c1aa5c5cec3dc70bb1f5687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5554766 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1305376}
This change adds paint holding for in-process subframe navigations when there is a ViewTransition by doing the following: 1. Assign the effect node which groups all content rendered by the iframe a ViewTransition resource ID. This ensures that the content doesn't paint into its target. It also ensures the content is cached into a texture in Viz. 2. Create a ViewTransitionContentLayer to draw the above render pass/ texture *after* painting the contents of the iframe. This ordering is important to ensure the PaintLayer for the iframe contents (which uses the above effect node) is painted before the new foreign layer. 3. The resource ID for the subframe contents is included in the ViewTransitionState for cross-document navigations. Change-Id: I805847e8a032c2f19d094b270ef57046578a4e69 Bug: 330920521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545686 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Joe Mason <joenotcharles@google.com> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Auto-Submit: Khushal Sagar <khushalsagar@chromium.org> Commit-Queue: Khushal Sagar <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1305425}
The `text-box-trim` should apply only to the top of the first fragment and the bottom of the last fragment, resolved at w3c/csswg-drafts#5335. This patch adds tests for this, `001` for when the `text-box-trim` is applied to the multicol container, and `002` for when a box with `text-box-trim` is block fragmented by ancestor multicol. Bug: 40254880 Change-Id: Ice29f39cbef0c20284edd809942754176a395d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5564105 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1305545}
Depends on D210731 Differential Revision: https://phabricator.services.mozilla.com/D210732 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1895738 gecko-commit: 58f32a0924c895a0240482a477f1aea72dddd44d gecko-reviewers: webdriver-reviewers, jdescottes
Depends on D209540 Differential Revision: https://phabricator.services.mozilla.com/D209541 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1850680 gecko-commit: 9a98ace82049ec685ce68c7a2b1c7f877be06532 gecko-reviewers: webdriver-reviewers, whimboo
* [WebDriver BiDi] Fix test for window.prompt opened * fix other test as well * Update webdriver/tests/bidi/browsing_context/user_prompt_opened/user_prompt_opened.py Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com> --------- Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
The IntersectionObserver recommends having more than 3px distance from the observed element and other nearby elements to help prevent false- positives. This enforces that recommendation by setting a minimum value for margins. Change-Id: I721607c2ea2fd7f2bacbd35c135cb113b187c657 Fixed: 342536398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5563210 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1305667}
Bug: 40946458 Change-Id: Ic21f7e533f26aeb3a7631dec329d7fa3d3f80585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5569391 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1305682}
This fixes an exploit that uses the ::before CSS pseudo-selector that displaces the text in the permission element and replaces it with content chosen by the author. The added test is modeled after the exploit. Fixed: 342355738 Change-Id: Id2f05a9febe3d2f97662065d5c1a46a6ade260f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5563204 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1305684}
The min/max-width/height properties for the permission element are bounded in an effort to prevent the width/height from going above/below certain hard-set limits. However the min-width/height will overrule the max-width/height if it's bigger. This means that the current restrictions can be bypassed in one direction by setting the min-width/height to very large values, as they are currently only lower bounded (restricted from being too small). This CL instead changes the logic to clamp the min-width/height so that it also has an upper bound. Fixed: 341947676 Change-Id: I6fe68b6d9f07e4041e5c4455fc34dce167b01be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5563906 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1305710}
Differential Revision: https://phabricator.services.mozilla.com/D211345 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1887644 gecko-commit: 6172cdacabdaad5b28b72fd7c8dc2397a1e7427d gecko-reviewers: webdriver-reviewers, whimboo
…e set accordingly Differential Revision: https://phabricator.services.mozilla.com/D211341 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1898468 gecko-commit: e4cd5d49fd0b509c41ff15d3f667fccd92dedf54 gecko-reviewers: layout-reviewers, emilio
This patch adds a content attribute parsing and a wpt test for contentvisibilityautostatechange event R=khushalsagar@chromium.org Change-Id: Iae610a794477d3ca0b346b752b489cd101399fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5570779 Commit-Queue: Vladimir Levin <vmpstr@chromium.org> Reviewed-by: Khushal Sagar <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1305905}
…ausing high frequency failures at url_patterns.py . CLOSED TREE Backed out changeset 2e388b7f6f91 (bug 1898565) Backed out changeset 3147811b0446 (bug 1850680) Backed out changeset 9a98ace82049 (bug 1850680) Backed out changeset 8ff3dc16fcf9 (bug 1850680) Backed out changeset 1c4084febc9c (bug 1850680) Backed out changeset aeeda14ca643 (bug 1850680) Backed out changeset fb750d3b365d (bug 1880803) Backed out changeset 4d63b73b4125 (bug 1880803) gecko-commit: c5f0d71de69cf598d009f69c9ddf56fb6058bc9e
Differential Revision: https://phabricator.services.mozilla.com/D211581 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1898409 gecko-commit: 8be119d3c4a47600746cefadd42695820dba8a12 gecko-reviewers: emilio
Currently the worker is always created as a Worker of the current document. With this we create it in the RC and assign it to the specified global variable. Fixed: 342275700 Change-Id: Ia8482f148b6aa4de7fb9bfb18af886287aa63297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5561812 Reviewed-by: Yuzu Saijo <yuzus@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1306239}
Following up crrev.com/c/5561849, this patch supports when `ClearanceAfterLine()` exists but 0, by changing it to `std::optional<LayoutUnit>`. Bug: 40254880 Change-Id: I407d6cf418b3e4765881ef454ca7f38e5d66338e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5564483 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1306284}
* The intrinsic inline-size of a ruby column fits in the available space of the current line, * There is no soft break opportunity at the end of the ruby column, and * The following text exceeds the available space. If the above conditions met, the entire ruby column was rewound though it has soft break opportunities. This CL supports breaking at the last soft break opportunity inside the ruby column. Bug: 324111880 Change-Id: Ia40ba37d552fae8f411834a7a1288a285cff9202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5569799 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1306306}
Bug: 40946458 Change-Id: Ia69c6ab45d45328b0647cdf5e1acc8adba284b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5569133 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1306364}
Normally, empty lines can exist only in an empty inline formatting context. But there are some rare cases where empty lines can exist in non-empty inline formatting context. When such empty lines are at the end of the inline formatting context, `RelayoutForTextBoxTrimEnd()` needs to let `InlineLayoutAlgorithm` know whether the line is the last non-empty line or not. This patch adds `ShouldForceTextBoxTrimEnd()` to communicate that information from `BlockLayoutAlgorithm` to `InlineLayoutAlgorithm`. Bug: 40254880 Change-Id: Ia440325c502db0dcc3c8f248cc3c7ec3588f7fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5568835 Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Lingqi Chi <lingqi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1306386}
Bug: 40946458 Change-Id: I23acf9a439a2df7c72aa658cf10b45228da0961e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5571342 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1306388}
This feature wasn't fully launched following the spec discussions, and a new approach is in progress for extending `TextMetrics`. We decided to remove the code for advances to keep everything organized. Bug: 341213359 Change-Id: Ifee0f4a500e942b457edf7890401d4ced134549e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5564324 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Andres Ricardo Perez <andresrperez@chromium.org> Reviewed-by: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/main@{#1306393}
Bug: 40946458 Change-Id: I674eb62e9739f7938325624f6005a71bec555654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5569743 Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1306399}
Bug: 40946458 Change-Id: I1fbdf113ee4d4f7d32d2c580108e967257ea3150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5569744 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1306413}
This CL changes the real-world-identity API IdentityRequestProvider#request parameter to be either an object or a string. This brings the implementation in line with the spec https://wicg.github.io/digital-credentials/ BUG=341316049 Change-Id: I24011854918f30c552bf80ec7de86b6e2d64b9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5546326 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Nicolás Peña <npm@chromium.org> Cr-Commit-Position: refs/heads/main@{#1306476}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )