Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go2rtc #11282

Closed
wants to merge 1 commit into from
Closed

Update go2rtc #11282

wants to merge 1 commit into from

Conversation

a2nt
Copy link

@a2nt a2nt commented May 7, 2024

I have tested it with Rockchip - works ok

ghcr.io/a2nt/frigate:dev-rk-98d1afcb-rk

Copy link

netlify bot commented May 7, 2024

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit aabf3d4
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/663aa3b916cc8d00081f0cc7

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented May 7, 2024

the docs and links need to be updated as well

@MarcA711
Copy link
Contributor

MarcA711 commented May 8, 2024

@a2nt I guess you are interested in hardware acceleration for Rockchip socs?
The hardware acceleration presets from this go2rtc version work only with the older FFmpeg fork from hbiyik. Frigate now uses the fork from nyanmisaka since it works better. The go2rtc presets need to be updated, see AlexxIT/go2rtc#979

Maybe it is better to update go2rtc after the presets were updated.

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented May 8, 2024

I think it is fine to update go2rtc now in general, there are many fixes in 1.9.0/1

@a2nt
Copy link
Author

a2nt commented May 8, 2024

@a2nt I guess you are interested in hardware acceleration for Rockchip socs? The hardware acceleration presets from this go2rtc version work only with the older FFmpeg fork from hbiyik. Frigate now uses the fork from nyanmisaka since it works better. The go2rtc presets need to be updated, see AlexxIT/go2rtc#979

Maybe it is better to update go2rtc after the presets were updated.

Hmmm I don't experience any performance issues.

Current go2rtc 1.8.5 version at frigate by AlexxIT has a bit higher CPU usage than 1.9.1 by AlexxIT using h264. I don't see big difference

But will look forward for updated presets

@NickM-27
Copy link
Sponsor Collaborator

this has been handled in a separate PR

@NickM-27 NickM-27 closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants