Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to "prisma": "4.6.1" #4062

Merged
merged 5 commits into from Feb 13, 2023
Merged

Conversation

tordans
Copy link
Contributor

@tordans tordans commented Jan 18, 2023

Closes: -

What are the changes and their implications?

Update Prisma from 4.6.0 to 4.6.1 to solve enum issue with PostgreSQL prisma/prisma#16180

Feature Checklist

  • Changeset added (run pnpm changeset in the root directory)
  • [-] Integration test added (see test docs if needed)
  • [-] Documentation added/updated (submit PR to blitzjs.com repo main branch)

@changeset-bot
Copy link

changeset-bot bot commented Jan 18, 2023

🦋 Changeset detected

Latest commit: db3d23e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@blitzjs/generator Patch
blitz Patch
@blitzjs/codemod Patch
@blitzjs/auth Patch
@blitzjs/next Patch
@blitzjs/rpc Patch
@blitzjs/config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tordans
Copy link
Contributor Author

tordans commented Jan 18, 2023

Looking through the release log https://github.com/prisma/prisma/releases from 4.6 to the current 4.9 I don't see any breaking changes. I wonder if Blitz should update to @latest?

@noxify
Copy link
Contributor

noxify commented Jan 28, 2023

@tordans - Prisma released Version 4.9.0 - maybe we should use this version directly?

@tordans
Copy link
Contributor Author

tordans commented Jan 28, 2023

This is just a minor change to address the enum bug. I did not test anything else...

@tordans
Copy link
Contributor Author

tordans commented Jan 31, 2023

@siddhsuresh I applied you code review; let me know if there is anything else – thanks!

Copy link
Member

@flybayer flybayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make that change to the changelog, otherwise good to go :)

@flybayer
Copy link
Member

flybayer commented Feb 7, 2023

lastly can you resolve the pnpm lock conflict? :)

tordans and others added 4 commits February 7, 2023 15:24
Update Prisma from `4.6.0` to `4.6.1` to solve enum issue with PostgreSQL prisma/prisma#16180
Co-Authored-By: Brandon Bayer <b@bayer.ws>
Co-Authored-By: Siddharth Suresh <siddh.suresh@gmail.com>
@tordans
Copy link
Contributor Author

tordans commented Feb 7, 2023

@flybayer I rebased and resolved the conflicts and ran & checked in pnpm install again to be sure all is consistent. That did a minor version update as it looks like but that should be OK.

@siddhsuresh siddhsuresh merged commit 430f0b5 into blitz-js:main Feb 13, 2023
@blitzjs-bot blitzjs-bot added this to Done in Toolkit Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants