fix: remove "already registered" warning, which triggered too many fa…

…lse positives (#211) * fix: remove "already registered" warning, which triggered too many false positives * remove warn test
blitz-js · Dec 6, 2022 · 38b25ed · 38b25ed
1 parent 2579e10
commit 38b25ed
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 17 deletions.
diff --git a/src/registry.test.ts b/src/registry.test.ts
@@ -16,14 +16,6 @@ test('class registry', () => {
 
   expect(() => registry.register(Car)).not.toThrow();
 
-  const warnSpy = jest.spyOn(console, 'debug');
-
-  registry.register(class Car {});
-  expect(warnSpy).toHaveBeenCalledTimes(1);
-  expect(warnSpy.mock.calls[0][0]).toContain(
-    'Ambiguous class "Car", provide a unique identifier.'
-  );
-
   registry.register(class Car {}, 'car2');
 
   expect(registry.getValue('car2')).not.toBeUndefined();

diff --git a/src/registry.ts b/src/registry.ts
@@ -14,15 +14,6 @@ export class Registry<T> {
       identifier = this.generateIdentifier(value);
     }
 
-    if (process.env.NODE_ENV !== 'production') {
-      const alreadyRegistered = this.kv.getByKey(identifier);
-      if (alreadyRegistered && alreadyRegistered !== value) {
-        console.debug(
-          `Ambiguous class "${identifier}", provide a unique identifier.`
-        );
-      }
-    }
-
     this.kv.set(identifier, value);
   }