-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not run changeset
linter in Version Packages PRs
#586
Conversation
run: | | ||
git pull --force --no-tags origin main:main ## https://github.com/changesets/changesets/issues/517 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this command one step up to reduce time gap between repo checkout and branch reference creation
changeset
in CI for Version Packageschangeset
linter in Version Packages PR
changeset
linter in Version Packages PRchangeset
linter in Version Packages PRs
Codecov Report
@@ Coverage Diff @@
## main #586 +/- ##
=======================================
Coverage 58.06% 58.06%
=======================================
Files 263 263
Lines 4149 4149
Branches 995 995
=======================================
Hits 2409 2409
Misses 1434 1434
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Continues #579, fixes CI failures in Version Packages PRs.
From docs:
See failed run example for #578
Extra: I’ve also bumped
@changesets/cli
to get this upstream PR in: changesets/changesets#905Older versions of
@changesets/cli
use built-in Prettier (v1). It generates lists with alternating*
and-
, which in turn breaksyarn lint:markdownint
. Upstream issues: changesets/changesets#938, prettier/prettier#4369.