Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use isInMainFile instead of isWrittenInMainFile in example #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use isInMainFile instead of isWrittenInMainFile in example #68

wants to merge 1 commit into from

Conversation

dbeer1
Copy link
Contributor

@dbeer1 dbeer1 commented Jan 31, 2022

Describe your changes
The example code should use isInMainFile instead of isWrittenInMainFile. The former correctly checks if a location is in a file and handles things like #line directives and macros.

Testing performed
Build and test

@dbeer1 dbeer1 requested a review from ruoso January 31, 2022 23:08
@dbeer1
Use isInMainFile instead of isWrittenInMainFile in example
69746a1 
Signed-off-by: Daniel Beer <dbeer1@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@envp envp envp approved these changes

@ruoso ruoso Awaiting requested review from ruoso

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dbeer1 @envp