Enhance mocking framework, return back CPP03 support, extend ntcr::StreamSocket test coverage #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
next round of simplifications introduce pass traits Fix Windows compilation for ntsu::SocketOptionUtil, add functionality to mock methods with 4 arguments, mock new send for ntcd::StreamSocket get rid of some MACROs count all arguments and matchers from 0 instead of 1 Unify NTF_EXPECT macro replace some macros with normal functions AIX compilation fixed Fix compilation on SunOS Add TC28 to ntcr_streamsocket.t Add TC29 and TC30 to ntcr_streamsocket.t Simplify mocking framework Add one more TC Add more TCs Add more TCs
smtrfnv
force-pushed
the
mock_framework_enhancement
branch
from
5c8d6c6
to
7d65778
Compare
|
@mattrm456 I think there was an issue with CI check and I have no permissions to restart it. Locally all tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
ntcr::StreamSocketntsi::Stream/DatagramSocket::send(ntsa::SendContext* context, const void* data, bsl::size_t size, const ntsa::SendOptions& options)to multiple children classes. @mattrm456 please pay attention to that part