馃挭 Typesafe pick, omit and pluck #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasgramlich
force-pushed
the
feature/typesafe-pick-omit-pluck
branch
from
fef9bf9
to
21ee47c
Compare
src/utils/omit.ts
Outdated
| @@ -0,0 +1,8 @@ | |||
| import * as Lodash from 'lodash'; | |||
|
|
|||
| export type Diff<T extends string, U extends string> = ({[P in T]: P } & {[P in U]: never } & { [x: string]: never })[T]; | |||
There was a problem hiding this comment.
Don't you think it's nicer like this, because it blends in amongst Pick<> and co?
There was a problem hiding this comment.
Makes sense indeed, could expose those as types BTW?
There was a problem hiding this comment.
You mean move them to the types directory?
SylvainEstevez
approved these changes
Dec 4, 2017
added 2 commits
December 4, 2017 13:31
|
Travis build is broken due to: npm/npm#17858 |
|
Build: 馃崗 after removing node_modules from cache. This repo is so small we'll be fine without caching |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.