Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow widgets from going behind header/footer bars #634

Open
ES-Alexander opened this issue Dec 11, 2023 · 3 comments · May be fixed by #911
Open

Disallow widgets from going behind header/footer bars #634

ES-Alexander opened this issue Dec 11, 2023 · 3 comments · May be fixed by #911
Assignees
@rafaellehmkuhl
Labels
accessibility bug Something isn't working P1 - Important Priority High priority task ui UI related issues ux Has to do with the user experience
Milestone
From Beta to Stable

Comments

@ES-Alexander
Copy link
Contributor

The header and footer bars (when visible) should be taken into account as invalid widget locations. It's quite disconcerting to resize the browser window and end up with some widgets partially covered by a bar.

This is the default map view, which doesn't seem reasonable:
Screenshot 2023-12-11 at 9 57 59 pm

The HUD has similar issues, with the compass at the bottom:
Screenshot 2023-12-11 at 10 01 22 pm

There may be some leeway for full-screen widgets to be permitted to go behind them (it's kind of nice for the map, and I'm unsure whether it would be problematic for the video stream), but I think at minimum everything else should be confined to within the accessible screen area.
@ES-Alexander ES-Alexander added bug Something isn't working ui UI related issues accessibility ux Has to do with the user experience labels Dec 11, 2023
@rafaellehmkuhl
Copy link
Member

Yes. That's indeed one of the things we should be working between beta and stable. Thanks for opening the issue.

@rafaellehmkuhl rafaellehmkuhl added this to the JustAfterBeta milestone Dec 11, 2023
@rafaellehmkuhl rafaellehmkuhl added P1 - Important Priority High priority task P2 - Normal Priority Task that should be done and removed P1 - Important Priority High priority task labels Dec 11, 2023
@rafaellehmkuhl rafaellehmkuhl added P1 - Important Priority High priority task and removed P2 - Normal Priority Task that should be done labels Dec 22, 2023
@pkmiles
Copy link

pkmiles commented Jan 5, 2024 •
edited

My two cents on this - to keep it simple:

  • Header and Footer bars can be consistent across all views, i.e. no need to make the content on these view specific.
  • View setting for whether it's full screen (under header / footer) or not.

Also, by doing this does it simplify the view builder interface since the Header / Footer bar "viewlets" becomes separated? That could be a UX win.

@rafaellehmkuhl
Copy link
Member

My two cents on this - to keep it simple:

  • Header and Footer bars can be consistent across all views, i.e. no need to make the content on these view specific.
  • View setting for whether it's full screen (under header / footer) or not.

Also, by doing this does it simplify the view builder interface since the Header / Footer bar "viewlets" becomes separated? That could be a UX win.

I'm not totally sure about that. It seems to me that there's value in being able to create different bar layouts. Maybe we can give the user the option to use the same on all and have the best of both worlds?

@rafaellehmkuhl rafaellehmkuhl self-assigned this Apr 18, 2024
@rafaellehmkuhl rafaellehmkuhl linked a pull request Apr 25, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafaellehmkuhl rafaellehmkuhl

Labels
accessibility bug Something isn't working P1 - Important Priority High priority task ui UI related issues ux Has to do with the user experience
Projects
Cockpit - Roadmap to Stable
Status: In tests
Milestone
From Beta to Stable
Development

Successfully merging a pull request may close this issue.

Move widgets away from bars rafaellehmkuhl/cockpit-public
4 participants
@rafaellehmkuhl @pkmiles @ArturoManzoli @ES-Alexander