Keep explicit newlines with help texts #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a difference for e.g. pytest-xdist:
Before:
```
--dist=distmode set mode for distributing tests to exec environments. each: …
available environment. loadscope: …
grouped by file to any available environment. (default) no: …
```
After:
```
--dist=distmode set mode for distributing tests to exec environments.
each: send each test to all available environments.
load: load balance by sending any pending test to any available environment.
…
(default) no: run tests inprocess, don't distribute.
```
This might also result in unexpected changes (hard wrapping), when line
endings where used unintentionally, e.g. with:
```
help="""
some long
help text
"""
```
But the benefits from that are worth it, and it is easy to fix, as will
be done for the internal `assertmode` option.
blueyed
added a commit
to blueyed/testmon
that referenced
this pull request
Feb 25, 2020
This is not relevant currently (i.e. causes no change), but I've changed it in blueyed/pytest#256 to split on newlines before wrapping it.
tarpas
pushed a commit
to tarpas/pytest-testmon
that referenced
this pull request
Feb 16, 2021
This is not relevant currently (i.e. causes no change), but I've changed it in blueyed/pytest#256 to split on newlines before wrapping it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a difference for e.g. pytest-xdist:
Before:
After:
This might also result in unexpected changes (hard wrapping), when line
endings where used unintentionally, e.g. with:
But the benefits from that are worth it, and it is easy to fix, as will be
done for the internal
assertmodeoption.Upstreamed: pytest-dev#6817