More robust loading of CJS plugins using require()
#141
+502
−436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For CJS plugins, we should just load them with Node's
require
function. This defers to Node on resolving/loading the package entry point, meaning we don't have to try to handle any of that logic ourselves. As a result, support for CJS plugins should be improved. This greater robustness means any file types (e.g. JSON) handled by require are also supported now.Only for ESM plugins do we need to manually try to resolve the package entry point to pass to the
import
function. That's because you can't just doimport('path/to/plugin')
for importing a local directory.import
does not automatically resolve anything, so we have to do attempt to do it ourselves by looking atexports
in package.json.Related to #140. Helps with #132.