Use arrays instead of CSV strings for config file types #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
changed the title
ddzz
approved these changes
Nov 27, 2022
bmish
force-pushed
the
array-types-not-csv
branch
2 times, most recently
from
baaff79
to
9b15801
Compare
bmish
force-pushed
the
array-types-not-csv
branch
from
9b15801
to
858987e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'my-config,馃構'['my-config', '馃構']'fixableAndHasSuggestions,deprecated'['fixableAndHasSuggestions', 'deprecated']'name,type'['name', 'type']Using actual arrays of the proper enum types is much safer, cleaner, and more elegant vs. having the user provide CSV strings. Actual arrays are easier to work with in JS/JSON objects and avoid hacks like using
.join(','). This also enables us to specify the actual enum types which provide the user with additional type information / type-checking capability.