Use TypeScript readonly
modifier for external/array types
#303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use TypeScript
readonly
keyword in many places. This prevents us from modifying certain properties/data, kind of like the ESLint no-param-reassign rule. It's best practice to avoid modifying input data like user-provided options.readonly
keyword on all internal array typesreadonly
keyword on all our publicGenerateOptions
option typesIf using
readonly
ends up causing any issues, we can relax some of this later.https://www.typescriptlang.org/docs/handbook/2/classes.html#readonly
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-4.html#a-new-syntax-for-readonlyarray