Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pytest.warns(None) #1

Closed
wants to merge 2 commits into from
Closed

remove pytest.warns(None) #1

wants to merge 2 commits into from

Conversation

bnavigator
Copy link
Owner

What do these changes do?

Fix a deprecated misuse of pytest.warns()

https://docs.pytest.org/en/latest/deprecations.html#using-pytest-warns-none

Since the test suire errors on any unfiltered warning anyway, these context manageres are not necessary.

Are there changes in behavior for the user?

No. Just the test suite

Related issue number

aio-libs#6663

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

test_session_close_awaitable() does the exact same thing and should throw a deprecation warning already which is caught by the general filter
@bnavigator bnavigator closed this Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant