Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add InvokeSimpleWithRawParam for multi params with same key name #262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alswl
Copy link

@alswl alswl commented Dec 2, 2021

InvokeJob did not support multi params with same key name. For example, in my case:

  APPLICATIONS demo-kustomize  
     
  CLUSTERS sigma-foo,sigma-bar

This will be allowed.

But in the original source, InvokeJob using the map to holds params, that will not support multi params with same name.

The HTTP protocol support multi value with same name. eg:

https://en.wikipedia.org/wiki/Query_string

Jenkins also support multi params with same name,
image

My solution is add InvokeSimpleWithRawParam to support raw url.Values, this class support using Add() add multi values with same name.

Signed-off-by: alswl alswlx@gmail.com

@alswl
Copy link
Author

alswl commented Dec 14, 2021

PING @bndr @figo .

@alswl
Copy link
Author

alswl commented Nov 15, 2022

Friendly ping after almost 1 years.
@bndr @figo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant