Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[builder] Change to facade #5036

Draft
wants to merge 33 commits into
base: master
Choose a base branch
from
Draft

[builder] Change to facade #5036

wants to merge 33 commits into from

Commits on Nov 13, 2023

  1. [tester] Add synchronous callback at start of test run 

    Fixes bndtools#5022

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    8ee1b10 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. [core] Made Central a service 

    Part of bndtools#5004

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    ca395f1 View commit details
    Browse the repository at this point in the history

  2. [builder] Change BndtoolsBuilder to facade pattern 

    Fixes bndtools#5004

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    bb2d3e2 View commit details
    Browse the repository at this point in the history

  3. [facade] Defer bc intialization 

    Originally, BundleContext (bc) was a static variable and initialized
statically. However, due to lazy activiation semantics, it would
sometimes get initialized to null as the bundle activation happens
*after* class initialization. Defering initialization of the field
using a Memoize fixes this problem.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    6d8ae34 View commit details
    Browse the repository at this point in the history

  4. [validators] Change validators to use services 

    Partially fixes bndtools#5005, bndtools#5004.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    9391978 View commit details
    Browse the repository at this point in the history

  5. [bndtools resource] Implement whiteboard for ResourceChangeListeners 

    Allows implementors of IResourceChangeListener to simply register
as services and they will automatically be installed.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    741f54a View commit details
    Browse the repository at this point in the history

  6. [search] Changed to use whiteboard for query listeners 

    This removes the last use of IStartupParticipant. Fixes bndtools#5005.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    7c142e1 View commit details
    Browse the repository at this point in the history

  7. [builder] Added regression tests for the builder 

    Fixes bndtools#5011

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    2871218 View commit details
    Browse the repository at this point in the history

  8. [builder test] Use wait utility that waits for autobuild to start 

    Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    e2e9073 View commit details
    Browse the repository at this point in the history

  9. [debug] Turned on more debugging to debug CI 

    Temporarily turn on debugging for review in case some CI failures
pop up that don't happen on local box. Expect that this commit will
be removed from the final PR.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    a10e550 View commit details
    Browse the repository at this point in the history

  10. [cnf] Make CnfWatcher dependent on Eclipse WS 

    Was previously dependent on Bnd workspace only.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    98c2e14 View commit details
    Browse the repository at this point in the history

  11. [central] Log an error if workspace initialization fails 

    Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    f189be2 View commit details
    Browse the repository at this point in the history

  12. [builder] Changed some components to use constructor injection 

    Also fixes a potential race condition (albeit rare) in the dynamic
reference provider where the isDefaultWorkspace() call was called
outside of the read lock, so there was potential for its default
status to change before the information could be retrieved.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    54b804f View commit details
    Browse the repository at this point in the history

  13. [builder] Custom facade implementation for ClasspathContainerInitializer 

    Because it is an abstract class rather than an interface the regular
ExtensionFacade approach will not work.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    19320e7 View commit details
    Browse the repository at this point in the history

  14. [bndtools test] Factor out importing of fodder bundles 

    Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    4b22e57 View commit details
    Browse the repository at this point in the history

  15. [bndtools test] Classpath tests 

    Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    cec33e2 View commit details
    Browse the repository at this point in the history

  16. [builder] Fixes after rebasing. 

    Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    1c3a82b View commit details
    Browse the repository at this point in the history

  17. [builder-facade] Changes to bring it up to speed on Java 17 

    Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    7734f86 View commit details
    Browse the repository at this point in the history

  18. [builder facade] Add appropriate dependencies on IWorkspace 

    Since the upgrade to Eclipse baseline of 2022-09, it seems that Eclipse
registers the workspace as an IWorkspace object. An exception stacktrace
even recommends depending on this using DS or similar instead of using the
static method ResourcePlugin.getWorkspace(). Adding this dependency fixes
some runtime startup ordering problems.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    0709792 View commit details
    Browse the repository at this point in the history

  19. [test] Re-enable bndtools.core.test 

    Hopefully the fixes to startup ordering in bndtools#5036 have fixed the flakiness
issues.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    0ffd476 View commit details
    Browse the repository at this point in the history

  20. [facade] Tweak component startup dependencies 

    The BndContainerInitializer incorrectly depended on Central instead of ICentral.
The Central component itself depended on the (Eclipse) Workspace, this has now
been changed to depend on the Workbench so that Central is not created too early,
which was causing a deadlock in the integration tests.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    09151e3 View commit details
    Browse the repository at this point in the history

  21. [bndtools test] Attempt to fix startup lockup 

    Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    3dd84ab View commit details
    Browse the repository at this point in the history

  22. [test] Temp commit to see if CI issues are Linux only 

    Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    466af16 View commit details
    Browse the repository at this point in the history

  23. [bndtools test] Depend on e4.IWorkbench instead of ui.IWorkbench 

    Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    2830bba View commit details
    Browse the repository at this point in the history

  24. [build] Re-enabled xvfb-run for integration tests 

    Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    3ed3fb3 View commit details
    Browse the repository at this point in the history

  25. [bndtools test] Changed to synchronize startup with Workbench 

    Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    34133cd View commit details
    Browse the repository at this point in the history

  26. [tester] Made startup callback use notification instead of polling 

    Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    734da99 View commit details
    Browse the repository at this point in the history

  27. [bndtools test] Further startup order dependency fixes 

    Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    16faf99 View commit details
    Browse the repository at this point in the history

  28. [bndtools test] Changed incremental to clean build 

    Hopefully this will fix a startup issue.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    3fa4877 View commit details
    Browse the repository at this point in the history

  29. [bndtools test] Revert buildClean(), add JavaCore initialization to s… 

    …tartup

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    e29431d View commit details
    Browse the repository at this point in the history

  30. [bndtools test] Disabled test on Java 20 in CI 

    Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    3b35384 View commit details
    Browse the repository at this point in the history

  31. [bndtools test] Removed EE spec in classpath 

    Specifying an explicit EE requires that EE to be registered in the workspace.
That is too hard...

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    1ce4c98 View commit details
    Browse the repository at this point in the history

  32. [bndtools test] Extra debugging prints to debug startup race condition 

    Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
    @kriegfrj
    kriegfrj committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    ddc7314 View commit details
    Browse the repository at this point in the history