WIP:[maven] use outputDir and waroutputDir correctly #5176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
|
It is unclear to me what problem you are solving. There is no issue describing the problem and there is no text in the pr or commit which describes the purpose of the change. The PR is also lacking tests for the change. |
|
A war file never goes in the web app directory. This is only for the exploded wab. What does appear to be missing is the exploding of the wab into the web app directory directory when using a packaging goal. I will make a new PR for that. |
|
See #5310. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
jarandtestjargoals / BndMavenPackagingTestsPlugin and BndMavenPackagingPlugin could be configures according the documentation using the confguration-propertiersoutputDirandwaroutputDir. But this properties are not used to save the jars in this position.TODO:
outputDirandwaroutputDirwork properly.waroutputDirandoutputDirnever worked we can decide to use onlyoutputDirectoryfor both like in maven-jar-plugin andmaven-war-plgin