Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[export] JPMS module info calculation fails #5258

Merged
merged 1 commit into from May 23, 2022
Merged

[export] JPMS module info calculation fails #5258

merged 1 commit into from May 23, 2022

Commits on May 23, 2022

  1. [export] JPMS module info calculation fails 

    There was a recent change bndtools@dd2f0c5 that took a shortcut to calculate the embedded packages unconditionally. It used the bundle class path analysis to analyze all the jars in the executable. 

However, this significantly slows down Eclipse but worse, it then tries to reinterpret the annotation headers. In my case, I got 3 types on the Bundle-Activator.

The analysis should only be done when it is needed and I'd suggest to do it either in a separate Builder or try to analyze the manifests for speedup.

This patch just makes the analysis conditional but that is a temporary fix to make it compatible with the the previous code.

This needs to be cherry picked for 6.3.0 since it is a very serious regression.

Fixes  bndtools#5257

Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
    @pkriens
    pkriens committed May 23, 2022
    Copy the full SHA
    92ede60 View commit details
    Browse the repository at this point in the history