[decoration] Backward compatibility #5261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current decoration rewrite was not backward compatible since it added literals for the `-runbundles`. After some discussion we decided to add `++` for decorations that add literals and a single `+` for the 6.2 behavior. Since we use the decoration in our own build, this patch first adds `++` syntax but both the single and double plus will add literals. After this works, we need to add test for the single `+` (not adding literals) and replace our own use of decoration to use double plusses where applicable. Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
|
@bjhargrave feel free to take over this PR and adjust, I can finish stuff then tomorrow |
Reminds me of 1998! :-) |
|
Closing this PR since you used your master branch and I did not want to push to it. So I opened a new PR #5262. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current decoration rewrite was not backward
compatible since it added literals for the
-runbundles.After some discussion we decided to add
++for decorationsthat add literals and a single
+for the 6.2 behavior.Since we use the decoration in our own build, this
patch first adds
++syntax but both the single and doubleplus will add literals.
After this works, we need to add test for the single
+(not adding literals) and replace our own use of decoration
to use double plusses where applicable.
Signed-off-by: Peter Kriens Peter.Kriens@aqute.biz