Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signing: Write META-INF signing resources immediately after manifest #5268

Merged
merged 4 commits into from May 28, 2022
Merged

signing: Write META-INF signing resources immediately after manifest #5268

merged 4 commits into from May 28, 2022

Commits on May 28, 2022

  1. signing: Remove old dead code 

    Signed-off-by: BJ Hargrave <bj@hargrave.dev>
    @bjhargrave
    bjhargrave committed May 28, 2022
    Configuration menu
    Copy the full SHA
    eaaed88 View commit details
    Browse the repository at this point in the history

  2. signing: Check for non-standard manifest name 

    Signing is only possible when using the standard manifest name.

Signed-off-by: BJ Hargrave <bj@hargrave.dev>
    @bjhargrave
    bjhargrave committed May 28, 2022
    Configuration menu
    Copy the full SHA
    a1bb0ea View commit details
    Browse the repository at this point in the history

  3. manifest: Use string constant for standard manifest name 

    Signed-off-by: BJ Hargrave <bj@hargrave.dev>
    @bjhargrave
    bjhargrave committed May 28, 2022
    Configuration menu
    Copy the full SHA
    922b0a9 View commit details
    Browse the repository at this point in the history

  4. signing: Write META-INF signing resources immediately after manifest 

    JarInputStream requires the META-INF signing resources to come
after the manifest and before any other resources. Otherwise,
JarInputStream does not consider the jar to be properly signed.

Later versions of Equinox now use JarInputStream to verify the
jar signing replacing Equinox's custom verification code. So Bnd
needs to properly generate signed jars to work with JarInputStream.

We also define a standard pattern for the META-INF signing resources
which is used by other classes that care.

Signed-off-by: BJ Hargrave <bj@hargrave.dev>
    @bjhargrave
    bjhargrave committed May 28, 2022
    Configuration menu
    Copy the full SHA
    37e7d2d View commit details
    Browse the repository at this point in the history