gradle: Make default Bundle-SymbolicName and Bundle-Version inputs #5280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleTaskExtension supports using the Jar manifest property to set attributes in the manifest main attribute section. However it did not properly handle the use of a Provider to supply the value. This fix is now in line with how the Gradle Manifest object handles converting attribute values to a String. Signed-off-by: BJ Hargrave <bj@hargrave.dev>
If Bundle-SymbolicName and/or Bundle-Version are not specified in the bnd instructions, then BundleTaskExtension will set default values based upon the Jar task's archiveBaseName, archiveClassifier, and archiveVersion properties. However, these Jar task properties are not considered inputs to the Jar task. They are just considered as parts of the archiveFile property which is an output property. Setting the defaults as input properties means that Gradle will consider them as part of the build cache key. This is important since the values can end up in the build jar's manifest. Fixes bndtools#5279 Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Bundle-SymbolicName and/or Bundle-Version are not specified in the
bnd instructions, then BundleTaskExtension will set default values
based upon the Jar task's archiveBaseName, archiveClassifier, and
archiveVersion properties. However, these Jar task properties are not
considered inputs to the Jar task. They are just considered as
parts of the archiveFile property which is an output property.
Setting the defaults as input properties means that Gradle will consider
them as part of the build cache key. This is important since the values
can end up in the build jar's manifest.
Fixes #5279