[resolve] Add cache mode #5304
Closed
[resolve] Add cache mode #5304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cache – Will use a cache file in the workspace cache. If that file is stale relative to the workspace or project or it does not exist, then the bnd(run) file will be resolved and the result is stored in the cache file. Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
bjhargrave
reviewed
Jul 1, 2022
| @@ -185,4 +194,100 @@ public Collection<Container> getRunbundles() throws Exception { | |||
| return super.getRunbundles(); | |||
| } | |||
|
|
|||
| private Collection<Container> cache() throws Exception { | |||
| File ours = getPropertiesFile(); | |||
There was a problem hiding this comment.
What about included files in the bndrun file and in the workspace?
In the gradle plugin all of the files factor in to out-of-date checks:
- Uses the project/workspace lastmodifiedtime, which includes include files - Removed removal of container errors in test, uses a resolve file that has proper dependencies - Added a testReason so the caching choice could be tested from outside - Increased test coverage Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
Merged
|
I guess we can close this PR since you merged #5305. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cache – Will use a cache file in the workspace cache. If that file is stale relative to the workspace or project or it does not exist, then the bnd(run) file will be resolved and the result is stored in the cache file.
Signed-off-by: Peter Kriens Peter.Kriens@aqute.biz