[mac m1] Added a bndrun file for the m1 #5347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lowest version SWT for the aarch64 architecture had a requirement on a later swt than we actually use. The platform swt jar was available from Maven central but unfortunately the fragment host swt jar not. I temporarily put the swt in a jars directory and patched the bndrun file from the x86 version since this does not support resolving. It would be nice if we could get this later swt & the swt aarch64 from the same place as all eclipse files so I leave this open for a discussion how to do this. Unfortunately, I ran into a deadlock when I ran the code. The builder gets a read lock on the workspace but calls refresh that tries to get a write lock. I've added a check for this and report an error if a read lock holder tries to get the write lock. However, I'd like to go to an Update/Read/Write lock as in https://github.com/npgall/concurrent-locks Also to discuss. Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lowest version SWT for the aarch64 architecture
had a requirement on a later swt than we actually
use. The platform swt jar was available from
Maven central but unfortunately the fragment host
swt jar not.
I temporarily put the swt in a jars directory
and patched the bndrun file from the x86 version
since this does not support resolving.
It would be nice if we could get this later swt & the
swt aarch64 from the same place as all eclipse files
so I leave this open for a discussion how to do this.
Unfortunately, I ran into a deadlock when I ran the
code. The builder gets a read lock on the workspace
but calls refresh that tries to get a write lock.
I've added a check for this and report an error if
a read lock holder tries to get the write lock.
However, I'd like to go to an Update/Read/Write
lock as in https://github.com/npgall/concurrent-locks
Also to discuss.
Signed-off-by: Peter Kriens Peter.Kriens@aqute.biz