[jpms] Fix calculation of module name with mult-release-jar dependencies #5360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds methods to the Jar class to read versioned content of a multi-release jar for the following cases: - get a resource or a map of resources for a given release version - get a merged manifest according to the OSGi specification - get module name/version for a given given release version - list all contained release alternative versions Beside this a unit-test is added to cover these new functions. Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
Fixes bndtools#5327 Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
laeubi
force-pushed
the
issue_5327_mr_jpms
branch
from
fe672e6
to
e2aafa9
Compare
This was referenced Dec 15, 2022
|
I will take over this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described here:
currently the JPMS Plugin incorrectly calculates the module name of dependencies that are multi-release jars if they are java 8 and java9+ as in this case no module-info.class is present at the default location.
This is based on
so if one want to see the changes from this PR only, simply select the last commit.
This will fix #5327
FYI @rotty3000 @stbischof