Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bndtools] Launch to bndrun #5829

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kriegfrj
Copy link
Contributor

This PR is a proof-of-concept. It will take a PDE .launch file and convert it into a .bndrun. The final .bndrun might still need some manual tweaking. It also assumes that you've done the work to convert the PDE target platform definition into Bnd respositories in your workspace.

There are two parts:

  1. biz.aQute.bnd.pde, which contains the actual utility that does the conversion;
  2. A context menu addition so that when you right-click on an xxx.launch file, you will have a menu item "Generate bndrun...". If you select it, it will create a corresponding xxx.bndrun file using the biz.aQute.bnd.pde library.

I am interested in feedback of all types. Is this a useful addition? Is the name appropriate? Is it in the right package? Should it be in its own bundle or rolled into another?

@kriegfrj kriegfrj marked this pull request as draft October 20, 2023 15:21
Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
@chrisrueger
Copy link
Contributor

chrisrueger commented Oct 20, 2023

Thanks a lot @kriegfrj . Could you maybe describe the usecase / purpose a bit more? Who would be the user of this feature and when would it be used? Is it meant as a helper during a migration to bndtools?

That context might help with feedback.

@kriegfrj
Copy link
Contributor Author

Sure,

Use case is for someone who wants to convert a project from PDE to Bndtòols. Part of that process includes having to convert PDE launch files into bndrun equivalents, for launching the frameworks. This tool automates a large part of that step.

@peterkir
Copy link
Contributor

Are the PRs can be checked as builded binaries (which can be installed and used in Eclipse) or do I have to test it from the source?

@kriegfrj
Copy link
Contributor Author

Are the PRs can be checked as builded binaries (which can be installed and used in Eclipse) or do I have to test it from the source?

The binaries are not publically available. There's two ways you could test it:

  1. From the Bndtools Eclipse test instance:
    1. Check out this branch of Bnd in your Bnd workspace in Eclipse.
    2. Browse to the bndtools.core project and run the bndtools.xxx.bndrun launch file (where xxx corresponds to the OS that you're running on). This will launch another Eclipse instance that has the current bundles installed.
  2. In your own Eclipse installation:
    1. Check out this branch of Bnd.
    2. Build the p2 repo locally (./gradlew p2 from the project root directory at the command line).
    3. In your Eclipse instance, do "Install new software" and add your local P2 repo.
    4. Install Bndtools from the local P2 repo and restart.

The first is probably easier.

@kriegfrj
Copy link
Contributor Author

Btw, thanks for being brave enough to consider giving it a try, @peterkir !

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants