Skip to content

Commit

Permalink
tools: don't gitignore base64 config.h
Browse files Browse the repository at this point in the history
The file is checked into git. Ignoring it causes a very non-obvious way
of breaking tarball builds:

1. Download and unpack tarball
2. Check the sources into git with `git init; git add .; git commit -a`
3. Clean the source tree with `git clean -dfx`
4. Run `./configure && make`
5. Observe build failure because config.h is missing

Fixes: nodejs#47638
  • Loading branch information
bnoordhuis committed May 25, 2023
1 parent 5275843 commit 1681c36
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions tools/dep_updaters/update-base64.sh
Expand Up @@ -51,6 +51,10 @@ mv "$WORKSPACE/base64" "$DEPS_DIR/base64/"
# to work, we create it and leave it empty.
echo "// Intentionally empty" >> "$DEPS_DIR/base64/base64/lib/config.h"

# Clear out .gitconfig, otherwise config.h is ignored. That's dangerous when
# people check in our tarballs into source control and run `git clean`.
echo "# Intentionally empty" >> "$DEPS_DIR/base64/base64/.gitconfig"

echo "All done!"
echo ""
echo "Please git add base64/base64, commit the new version:"
Expand Down

0 comments on commit 1681c36

Please sign in to comment.