Skip to content

Commit

Permalink
deps: don't gitignore base64 config.h
Browse files Browse the repository at this point in the history
The file is checked into git. Ignoring it causes a very non-obvious way
of breaking tarball builds:

1. Download and unpack tarball
2. Check the sources into git with `git init; git add .; git commit -a`
3. Clean the source tree with `git clean -dfx`
4. Run `./configure && make`
5. Observe build failure because config.h is missing

Fixes: nodejs#47638
  • Loading branch information
bnoordhuis committed May 25, 2023
1 parent 5275843 commit b4a61d7
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion deps/base64/base64/.gitignore
@@ -1,6 +1,5 @@
*.o
bin/base64
lib/config.h
test/benchmark
test/test_base64

Expand Down

0 comments on commit b4a61d7

Please sign in to comment.