Skip to content

Commit

Permalink
build: build with -D_FILE_OFFSET_BITS=64 again
Browse files Browse the repository at this point in the history
Faulty logic in commit fdf7c2a ("build: split off tests into separate
gyp file") accidentally disabled `-D_FILE_OFFSET_BITS=64` on Unices,
breaking file operations on files > 2 GB on 32 bits platforms.

Fixes: nodejs/node#19455
PR-URL: libuv#1779
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
  • Loading branch information
bnoordhuis committed Mar 21, 2018
1 parent 7e865b6 commit ee875f9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions uv.gyp
Expand Up @@ -2,12 +2,12 @@
'variables': {
'conditions': [
['OS=="win"', {
'shared_unix_defines': [ ],
}, {
'shared_unix_defines': [
'_LARGEFILE_SOURCE',
'_FILE_OFFSET_BITS=64',
],
}, {
'shared_unix_defines': [ ],
}],
['OS in "mac ios"', {
'shared_mac_defines': [ '_DARWIN_USE_64_BIT_INODE=1' ],
Expand Down

0 comments on commit ee875f9

Please sign in to comment.