Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable prebuilt binaries through Github actions #159

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

qwertzguy
Copy link

@qwertzguy qwertzguy commented Apr 4, 2021

Resolves #152

@qwertzguy qwertzguy marked this pull request as draft April 4, 2021 06:47
@qwertzguy qwertzguy marked this pull request as ready for review April 4, 2021 06:59
@qwertzguy
Copy link
Author

Verified that it is able to compile the binaries: https://github.com/qwertzguy/node-heapdump/pull/1/checks?sha=0fa0b311158c85ba142ec335e9bace9a5c7ff415

For it to work, it requires a maintainer to create a github token: https://www.npmjs.com/package/prebuild#create-github-token and then add it in the Settings tab of the repo > Secrets > Name: GITHUB_TOKEN.

It should then run when a new tag starting with the letter "v" is pushed.

Copy link
Owner

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! Just one question.

.github/workflows/prebuild.yml Outdated Show resolved Hide resolved
@qwertzguy
Copy link
Author

Let me know if you're ready to merge this. After merging, you would need to follow the steps from my previous comment to setup the github token.

@qwertzguy
Copy link
Author

Hi @bnoordhuis Is it possible to give me write access to be able to merge this? Or can you merge it?

@williamoliveira
Copy link

williamoliveira commented Apr 23, 2021

Could you make it prebuild for alpine also? (or is it already?)

@bnoordhuis
Copy link
Owner

For it to work, it requires a maintainer to create a github token: https://www.npmjs.com/package/prebuild#create-github-token and then add it in the Settings tab of the repo > Secrets > Name: GITHUB_TOKEN.

Sorry for the delay. I got stuck back then trying to figure out how to scope the personal access token to a single repo. Anyone know if that's possible?

@qwertzguy
Copy link
Author

@kentcdodds
Copy link

I'd really appreciate getting this across the finish line (along with docs showing how to use it). I'm trying to figure out an apparent memory leak that's only reproducing on prod. Anything I can do to help? The machine user solution looks good to me.

kentcdodds added a commit to kentcdodds/kentcdodds.com that referenced this pull request Nov 24, 2022
@qwertzguy
Copy link
Author

It requires a maintainer to do the steps I outlined in the 2nd comment.

max00317 pushed a commit to max00317/kent-remix that referenced this pull request Apr 1, 2023
This reverts commit 84d522c5a6475a24eca0448778d1af4562dcac80.

bnoordhuis/node-heapdump#159
romandev0318 pushed a commit to romandev0318/kentcdodds.com that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is there prebuilt binary available?
4 participants