Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically downgrade plugin artifact when possible #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bnorm
Copy link
Owner

@bnorm bnorm commented Mar 13, 2022

No description provided.

Copy link
Contributor

@TWiStErRob TWiStErRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice idea, didn't look too deep though.

val (major, minor, patch) = "(\\d+)\\.(\\d+)\\.(\\d+).*".toRegex().matchEntire(version)?.destructured
?: throw IllegalArgumentException("Cannot parse Kotlin compiler version: $version")
val kotlinCompilerVersion = KotlinVersion(major.toInt(), minor.toInt(), patch.toInt())
KotlinVersion(1, 3, 60)..KotlinVersion(1, 3, 60)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks strange

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some dead code. Was messing around with different options for the when statement and looks like I accidentally left it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants